Implement Feeds for ux2

Bug #1013698 reported by Paul Everitt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Medium
JimPGlenn

Bug Description

Carlos has already started on this. There is work remaining on the styling of the buttons in the top right. Carlos, if all that remains is styling and you want to hand to Blaise, re-assign this.

Tags: feeds ux2
Revision history for this message
Carlos de la Guardia (cguardia) wrote :

Blaise, I think everything here works, but the styles need some serious work. Let me know if you need any help.

Changed in karl3:
assignee: Carlos de la Guardia (cguardia) → blaflamme (blaise-laflamme)
status: New → In Progress
JimPGlenn (jpglenn09)
Changed in karl3:
milestone: m107 → m108
Revision history for this message
Nat Katin-Borland (nborland) wrote :

I know this is still in progress, but the Feeds menu still looks a bit sloppy (see screenshot). The screenshot is from IE, but the little grey dividers between the filter options don't look that great in any browser.

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Moving this to next week. We might have to re-invent that box to be more Bootstrap-y.

Changed in karl3:
milestone: m108 → m109
Changed in karl3:
assignee: blaflamme (blaise-laflamme) → JimPGlenn (jpglenn09)
status: In Progress → Fix Committed
Revision history for this message
JimPGlenn (jpglenn09) wrote :

The problem Nat identified in screenshot still appears on karl/dev. What branch did you put the fix to this bug?

Changed in karl3:
status: Fix Committed → In Progress
assignee: JimPGlenn (jpglenn09) → blaflamme (blaise-laflamme)
Revision history for this message
blaflamme (blaise-laflamme) wrote :

it was pushed on ux2 branch, however I don't know how it's deployed. Do the box has a bootstrapy style?

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

I went here:

https://karldev.gocept.com/ux2/osf/contentfeeds.html

...and the feeds menu in UX2 looked really good.

Changed in karl3:
assignee: blaflamme (blaise-laflamme) → JimPGlenn (jpglenn09)
milestone: m109 → m110
status: In Progress → Fix Committed
Revision history for this message
JimPGlenn (jpglenn09) wrote :

I went to https://karldev.gocept.com/ux2/osf/contentfeeds.html and it looked good for FF13.0.1 Mac, FF7 for Windows and IE 8 still had the problem see new screenshot for IE8.

Changed in karl3:
status: Fix Committed → In Progress
assignee: JimPGlenn (jpglenn09) → blaflamme (blaise-laflamme)
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Blaise, I think this one should take around 5 minutes to fix. Looks like we just need another pixel of vertical padding, to allow IE8 to let the margin-right go all the way over.

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

The one remaining issue on this is actually covered in lp:1006487 so I'll consider this one closed.

Changed in karl3:
assignee: blaflamme (blaise-laflamme) → JimPGlenn (jpglenn09)
status: In Progress → Fix Committed
Revision history for this message
JimPGlenn (jpglenn09) wrote :

looks good

tags: added: tested
JimPGlenn (jpglenn09)
tags: added: r3.90
Revision history for this message
Nat Katin-Borland (nborland) wrote :

The formatting looks good now, but the Feeds menu buttons are not working. The only choice you can actually click on is "All". If you click on "My Communities" or "My Content", nothing happens. This is the case across all browsers.

Changed in karl3:
status: Fix Committed → In Progress
JimPGlenn (jpglenn09)
Changed in karl3:
assignee: JimPGlenn (jpglenn09) → blaflamme (blaise-laflamme)
tags: removed: r3.90 tested
Changed in karl3:
milestone: m110 → m111
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

I extracted the remaining bug into lp:1024633 and thus I believe the rest of this ticket is done and in production. Marking Fix Released.

Changed in karl3:
assignee: blaflamme (blaise-laflamme) → JimPGlenn (jpglenn09)
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.