gerrit error with sync-gerrit-changes.py

Bug #1013577 reported by Milo Casagrande
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro patch metrics
Fix Released
High
Milo Casagrande

Bug Description

Since a couple of days we are getting GerritError from the cronjob that executes 'sync-gerrit-changes.py'.

I attach the output of the error we receive.

Related branches

Revision history for this message
Milo Casagrande (milo) wrote :
Milo Casagrande (milo)
Changed in linaro-patchmetrics:
assignee: nobody → Milo Casagrande (milo)
Milo Casagrande (milo)
Changed in linaro-patchmetrics:
milestone: none → 2012.06
importance: Undecided → Medium
Revision history for this message
Milo Casagrande (milo) wrote :

Update on this bug:
The problem here is that the version of gerrit of android-review is rather recent, a patched version from the latest release. What this new patched version introduced, is that quite a lot of JSON-RPC calls have been removed with a newly, undocumented, REST API.

Undocumented in the sense that there is not a real 1:1 comparison of the old RPC with the new REST calls, so other than guessing a little bit from the code, talking on IRC with gerrit developers, and using FireBug on android-review to see what happens, there is not much else that can be done.

I have a rather complete query string that might substitute the JSON-RPC call we were using, I have to better test it locally and see if the JSON output we get from this new version is the same or compatible as the old one (hopefully it is...).

Changed in linaro-patchmetrics:
status: New → Confirmed
importance: Medium → High
Milo Casagrande (milo)
Changed in linaro-patchmetrics:
status: Confirmed → In Progress
Revision history for this message
Milo Casagrande (milo) wrote :

This is a sample of the JSON output we get using the new REST API from Gerrit master. It is a sample with two results.

Revision history for this message
Milo Casagrande (milo) wrote :

This is a sample of the JSON output we get using the old JSON-RPC from Gerrit. It is a sample with two results.

Revision history for this message
Milo Casagrande (milo) wrote :
Milo Casagrande (milo)
Changed in linaro-patchmetrics:
status: In Progress → Fix Committed
Milo Casagrande (milo)
Changed in linaro-patchmetrics:
status: Fix Committed → In Progress
Revision history for this message
Milo Casagrande (milo) wrote :

We are still getting the error from Gerrit, even if it now looks different, it should have picked up the latest changes. I do not understand why though it raises anyway the exception: the old matching string was slightly different, but it shouldn't have be an issue.

Milo Casagrande (milo)
Changed in linaro-patchmetrics:
status: In Progress → Fix Committed
Revision history for this message
Milo Casagrande (milo) wrote :

Still get an error with some emails (not valid). We need to "quote" them.

Changed in linaro-patchmetrics:
status: Fix Committed → In Progress
Changed in linaro-patchmetrics:
status: In Progress → Fix Committed
Milo Casagrande (milo)
Changed in linaro-patchmetrics:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.