TextNode::set_text_scale does not properly handle spaces

[SamL]

http://www.panda3d.org/forums/viewtopic.php?t=13455

It appears that 1.8.0 and HEAD TextNode::set_text_scale does not properly handle spaces. They do not get scaled, so it appears that text is rendered without spaces.

The bug is in TextAssembler::assemble_row where the handling for spaces (and tabs) does not account for scaling.
"
    if (character == ' ') {
      // A space is a special case.
      xpos += font->get_space_advance();
"

should change to:
"
    if (character == ' ') {
      // A space is a special case.
      xpos += properties->get_glyph_scale() * properties->get_text_scale() * font->get_space_advance();
"

Can someone review and apply?

[SamL (saml-launchpad)]

Here's the actual patch, hopefully this can be included.

(sorry about security toggling, this launchpad is pretty touchy if you randomly click).

[Josh Enes (joshenes)]

I can confirm that this bug still exists and that the provided patch fixes the bug.

I used the following code to expose the bug, which is fixed after applying the patch.
Pressing space toggles scaling the text using two different methods, using setTextScale, and using setScale on the NodePath.
Without the patch, only the NodePath scale works properly.

from panda3d.core import *
from direct.showbase.ShowBase import ShowBase

class Game(ShowBase):
    def __init__(self):
        ShowBase.__init__(self)
        self.text = TextNode('my text node')
        self.text_np = NodePath(self.text)
        self.text_np.reparentTo(render2d)
        self.text.setText('hello world')
        self.accept('space', self.swap_scales)
        self.text_np.setScale(0.1)
        self.text.setTextScale(1.0)

    def swap_scales(self):
        np_scale = self.text_np.getScale()
        text_scale = self.text.getTextScale()
        self.text_np.setScale(text_scale)
        self.text.setTextScale(np_scale[0])
        self.text.forceUpdate()

Game().run()

[rdb (rdb)]

Many thanks! I've committed the patch. Sorry for taking so long to get to it, I just wasn't convinced that this isn't the intended behaviour; but that case makes it reasonably clear.