Popovers don't support theming

Bug #1013328 reported by Satyajit Sahoo
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Granite
Invalid
Undecided
Unassigned
Wingpanel
Fix Released
Low
Unassigned

Bug Description

The background color and the text color of the popovers (except Slingshot) don't respect the theme.

Tags: popover
summary: - Popovers doesn't support theming
+ Popovers don't support theming
Cody Garver (codygarver)
tags: added: popover
Revision history for this message
Danielle Foré (danrabbit) wrote :

This is definitely invalid for Granite. Granite's popovers are theme-able.

Changed in granite:
status: New → Invalid
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

I can confirm it for Wingpanel under Ambiance; it does use some theme preferences but not all of them, which leads to unreadable text.

Changed in wingpanel:
status: New → Confirmed
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Confirming with ambiance and a handful of other themes. We should definitely have it use theme colors. Right now it pretty much only works in eGTK which isn't nice when we can and should support standard theming.

Revision history for this message
Satyajit Sahoo (satyajit-happy) wrote :

Also, I forgot to mention, why it inherits styles from standard menu class? It doesn't look like a normal menu.

The problem is, if I specify a border or inset shadow in the menu, then it appears in the popover, which would have been ok if it fitted the nice rounded shape of the popover. But the shape of the shadow is a rectangle, like a menu, and not the same as the shape of the popover.

P.S. - Inset shadows are supported in the built-in engine and Adwaita engine.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Lucas just committed a fix that should have them more-or-less follow the menu style.

Changed in wingpanel:
status: Confirmed → Fix Committed
milestone: none → luna-beta1
David Gomes (davidgomes)
Changed in wingpanel:
importance: Undecided → Low
Changed in wingpanel:
status: Fix Committed → Fix Released
Revision history for this message
Satyajit Sahoo (satyajit-happy) wrote :

The bug is not fixed. Also they cannot be themed in GTK 3.8.

Revision history for this message
Satyajit Sahoo (satyajit-happy) wrote :
Revision history for this message
Satyajit Sahoo (satyajit-happy) wrote :

#6 is the inset box shadow issue I mentioned in #4

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.