Staff Client Title Sort ignores non-filing indicator information

Bug #1012308 reported by Thomas Berezansky
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

The branch below teaches ModsParser to generate a "titlesort" value for mvr entries, and then the staff client to use it for sorting. I tested in holds interfaces, which is where our members have noted it not working.

This won't help dummy titles where we don't have real MARC records, nor will it help incorrectly cataloged titles.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/title_sort

Tags: signedoff
Revision history for this message
Thomas Berezansky (tsbere) wrote :

For testing purposes, when I load the concerto set the following bib records have non-filing indicator information in the 245:

1
2
21
22
32
40
45
46
47
49
63
93

I picked 5 of those and 5 that were not in that list for my own test.

Changed in evergreen:
status: New → Triaged
Revision history for this message
Kathy Lussier (klussier) wrote :

Just tried to load this branch on a MassLNC Sandbox, but it looks like it needs to be rebased.

Revision history for this message
Michele Morgan (mmorgan) wrote :

Tested this on a MassLNC Sandbox. Most titles are sorting correctly, but there is still a problem when the first character after the filing indicator is lower case. These are sorting after all the upper case characters. Working with the concerto dataset, here is a screenshot of the item status screen sorted by Title by clicking on the Title column header.

http://screencast.com/t/9on8mqZclI

All those titles with lower case first filing characters are at the end

After editing record 49 so that that first filing character is upper case, the sort changes:

http://screencast.com/t/ivCDrdVb

Upper and lower case letters should be interfiled in this case.

Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Revision history for this message
Michele Morgan (mmorgan) wrote :

Signed off on this at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/LP_1012308_title_sort_honors_filing_indicators_signoff

The issue of upper and lower case characters needing to be interfiled remains, opened a new bug for that:

https://bugs.launchpad.net/evergreen/+bug/1391314

tags: added: signedoff
removed: pullrequest
Changed in evergreen:
assignee: Michele Morgan (mmorgan) → nobody
Revision history for this message
Ben Shum (bshum) wrote :

Picked to master with Michele's signoff (only grabbed the pertinent commit from the working branch).

Changed in evergreen:
status: Triaged → Fix Committed
milestone: none → 2.next
Revision history for this message
Ben Shum (bshum) wrote :

Changing milestone to reflect real target of 2.8 series - 2.8 beta, here we come!

Changed in evergreen:
milestone: 2.next → 2.8-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.