Unify ApplicationReview and TransitionLog models
Bug #1011855 reported by
Anthony Lenton
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Developer registration portal |
Fix Released
|
Low
|
Unassigned |
Bug Description
The ApplicationReview and TransitionLog models are very similar in essence.
The TransitionLog even has a comment field that could be used for the ApplicationReview's comment field. There is no user currently associated to the TransitionLog, but would make sense to be able to keep track of who exactly triggered each transition.
Changed in developer-portal: | |
status: | New → Confirmed |
importance: | Undecided → Low |
Changed in developer-portal: | |
status: | Confirmed → Fix Released |
milestone: | none → 12.09.2 |
To post a comment you must log in.
Some notes for a pre-imp discussion:
Uses of transition log: date_published tractor. queryset_ for_limits [1]
* Calculating Application.
* AppStateStatsEx
* fix_app_transitions would be updated quite simply.
* app_reviews_report would require simple changes - and could be moved to devportal.
Possible issues:
* Currently an application review/comment can be added without changing the state, where as transition logs implicitly assume that there is one item per transition. This would affect things like the queries for apps in a certain state at a certain time.
- Perhaps non-transitioning items should be identifiable - no state and no end_timestamp?
Other things tractor could be moved to devportal quite easily. tractor. .. which checks the subscriptions related application's price... Why can't we just check the subscription's purchased_price? Probably campaigns? Perhaps we can include the price on the PublishedApplic ation? Or better, PublishedApplic ation.is_ free_app? duration (instead of start timestamp) or similar, which would simplify some queries that collate to get duration average. Hrm, although there are querie using both timestamp and end_timestamp.
* AppStateStatsEx
* Could almost remove all refs to Application from sca/stats.py - except for PaidAppsStatsEx
* Could also add TransitionLog.
[1] Based on the usage, it looks like TransitionLog. end_state should really be TransitionLog. entered_ state?