Starting error on PlateformResolver

Bug #1011836 reported by hilaire
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Dr. Geo
Fix Released
Critical
Esteban Lorenzano

Bug Description

The error at start up is from the PlateformResolver>>forCurrentPlatefrom

It detect plateform as iPhone, but there are no iPhoneResolver so we
need one.

Hi,

I am just looking at those senders (in PharoCore 1.3 not very fresh).
And I can see some breakage intorducing a platform with new name can
cause.

e. g.:

defaultEncodingName
 | platformName osVersion |
 platformName := OSPlatform platformName.
 osVersion := OSPlatform osVersion.
 OSPlatform isWin32CE ifTrue: [^'utf-8' copy].
 (#('Win32') includes: platformName)
  ifTrue: [^'cp-1252' copy].
 (#('unix') includes: platformName) ifTrue: [^'iso8859-15' copy].
 ^'mac-roman'

if it is neither unix nor windows, it is assumed to be mac Although
the choice of iso8859-15 seems a bit deliberate as well - why not
utf-8 these days

We may need a new method like OsPlatformClass isAndroid (or to make
isUnix return true for Android)

But these are benign.

Workspace intialize will not know which line ending to use although
this is clearly as in the Unix case when running under Android.

For may reasons, Android approximates the Unix environment.

Tags: ipad
Changed in drgeo:
importance: Undecided → Critical
assignee: nobody → Esteban Lorenzano (estebanlm)
milestone: none → 12.07
Revision history for this message
Esteban Lorenzano (estebanlm) wrote :

you have an IOSResponder, in iPhone-Events package. That's the appropiate (yes, probably VM should answer iOS instead iPhone... historical issues)

Revision history for this message
hilaire (hilaire-fernandes) wrote : Re: [Bug 1011836] Re: Starting error on PlateformResolver

On 11/06/2012 22:42, Esteban Lorenzano wrote:
> you have an IOSResponder, in iPhone-Events package. That's the
> appropiate (yes, probably VM should answer iOS instead iPhone...
> historical issues)
>

Can you commit the necessary changes to get rid of it.

Thanks

Hilaire

--
Dr. Geo -- http://drgeo.eu

Revision history for this message
Esteban Lorenzano (estebanlm) wrote :

I don't understand. AFAIK, it is there... what is missing?

Revision history for this message
hilaire (hilaire-fernandes) wrote :

On 12/06/2012 18:10, Esteban Lorenzano wrote:
> I don't understand. AFAIK, it is there... what is missing?
>

So it should work out of the box with your new iPhone package?

Hilaire

--
Dr. Geo -- http://drgeo.eu

Revision history for this message
hilaire (hilaire-fernandes) wrote :

It works out of the box.

On 12/06/2012 19:36, Hilaire Fernandes wrote:
> On 12/06/2012 18:10, Esteban Lorenzano wrote:
>> I don't understand. AFAIK, it is there... what is missing?
>>
> So it should work out of the box with your new iPhone package?
>
> Hilaire
>
>

--
Dr. Geo -- http://drgeo.eu

Changed in drgeo:
status: New → Fix Committed
Changed in drgeo:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.