[charts] dashboard giving traceback

[Jigar A.]

With recently added new lib for the chart, few dashboard does not seems working perfectly in web client.
I have tested the problem in local as well as on run bot at following revision :
(Build 10686), server (4191), addons (6882), web (2528).
When I open Dashboard or the account, hr and project, I found various issues.
For more ref, I have attached the video with the bug, Kindly refer it.
Thank You

[Vidhin Mehta (OpenERP) (vme-openerp)]

In accouting chart, when call "account.account"'s read_group, overidden method read_group of "account_entries_report" called,because of that wrong data comes to evalution in graph.py and error occurs.

In Sales and hr chart when list of record.data is blank in graph.js and error occurs, attach patch for that.

[Jiten (OpenERP) (jiten-openerp)]

Hello,

This issue is partially affects to two diff projects like web and server both.

From the web side, this issue fixed in branch like,
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-1011492-pan.

So, by this fixed dashboard works fine for hr, project and others But,
For the accounting dashboard, It should be fixed from server side.

After trace all the code, we found that in orm.py method read_group does not fatch field 'balance' from database and it is a functional field.

So, client does not get 'balance' field key.

Thanks.

[ajay javiya (OpenERP) (aja-openerp)]

Hello,
We have traced issue and partially i do agree with comment #3. As mention comment #2 read_group is not reading fields.function which are not store in database as classic read,write is not allowed on that.
if we want any fields.function on dashboard better to make it store=True, Which can be done from addons. As follows
patch:http://paste.ubuntu.com/1175226/
 i request community to move bug to right project.
Thanks

[Amit Parik (amit-parik)]

Hello All,

The account dashboard 'e error comes from the addons side because the balance field is a function field without store and non-stored function fields should not be used in read_group.

Also I agree with Ajay, We can't do on server-side in read_group, as we cannot allow grouping on non-stored function fields.It would required computing the function field value for the whole database, which could have millions of records

Also on addons side we must not make the balance field stored, because it is a critical field that must always be correct, and making it stored would add a risk of having it become out of sync with the actual balance (many things can affect the balance, like structure of chart of account, move, move.lines, etc.)

I would like to assign this issue into addons team and please properly fix the chart definition for the financial part without making store="True'.

Thank you!

[Saurang Suthar(OpenERP) (ssu-openerp)]

Hello,

I have tested this issue on runbot with latest trunk and it can't be reproduced now.

Thank you.
Saurang Suthar

[Nicolas Vanhoren (OpenERP) (niv-openerp)]

Since it can't be reproduced any more, I consider this bug is fixed.