Sound recorder can not play after recording and saving the first one

[Ding Zhou]

Impact:
Sound recorder can not play after recording and saving the first one

Test Case:

This issue can be reproduced both in standard Ubuntu 11.10 and Ubuntu 12.04.

How to reproduce:

1. First open Sound Recorder (gnome-sound-recorder), press "Record" button to record for seconds.
2. Press "Stop" button to stop record
3. Press "Play" button to play the sound, it is OK by now.
4. Now press "Record" again, it will prompt you to save the previous record, just save it.
5. After saving the last record, it will start to record. Seconds later, press "Stop" button to stop record.
6. Press "Play" button

Expect result:

It will play the record

Actual result:

It showed an error dialog with "Resource not found" (In Chinese: 资源未找到)

Regression potential:
the second record could still not play correctly

[Sebastien Bacher (seb128)]

thanks, that seems a bit similar to bug #412738

[Steve Magoun (smagoun)]

I can only reproduce the error dialog if I save the first recording. If I don't save the first recording, the second sound plays back without error. Tested with gnome-media 3.4.0-0ubuntu2 on precise.

[Sebastien Bacher (seb128)]

Confirmed there, saving the second recording also workaround the issue (i.e you can hit play after saving)

[James M. Leddy (jm-leddy)]

Fixes the problem for me

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "07_fix_play_after_savel.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Sebastien Bacher (seb128)]

Thanks James, could you give some explanation about the change or a description of what was the bug and how you addressed it?
Did you forward the bug to bugzilla.gnome.org or should we do it (bonus point if you do ;-)

I'm subscribing ubuntu-sponsors to the bug so it gets in the sponsoring queue for review

[James M. Leddy (jm-leddy)]

Thanks! I was planning on fwding to the gnome bugzilla but haven't gotten around to it yet. What the patch does is reinitialize a state variable when recording a new file so that clicking "play" doesn't try to play a previously saved (and now closed fd) file. This bug hit's anytime the recording is saved, even if it's saved with ctrl+s or similar since that's what changes the state variable.

[James M. Leddy (jm-leddy)]

Opened gnome-bugs #679003.

[Sebastien Bacher (seb128)]

Thanks guys, I've sponsored the fix, that resolved the error indeed, I'm not sure it's 100% correct though, the behaviour is a bit confusing, if you:

- start a record
- stop it
- save it
- start a second record
- stop it
- press "play"

it will play the first record and not the one you just did ... is that wanted? if you save the buffer on disk it will play it correctly. Ideally we would want to play whatever is in the buffer no?

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-media - 3.4.0-0ubuntu4

---------------
gnome-media (3.4.0-0ubuntu4) quantal; urgency=low

  * debian/patches/git_play_after_second_record.patch:
    - "Properly reinitialize when starting a new recording",
       should fix playing of records after the first saved one,
       thanks James M Leddy (lp: #1011436)
 -- Sebastien Bacher <email address hidden> Wed, 04 Jul 2012 18:01:35 +0200

[James M. Leddy (jm-leddy)]

In response to comment #10, yeah that still sounds wrong, I didn't notice when I was doing my testing. I'll open a new bug and investigate a fix.

[Sebastien Bacher (seb128)]

Thanks James!

[Brian Murray (brian-murray)]

Hello Ding, or anyone else affected,

Accepted gnome-media into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gnome-media/3.4.0-0ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Ding Zhou (tualatrix)]

Thanks for the fix.

I upgraded gnome-media to 3.4.0-0ubuntu4 and had a test, now the second record can play, but still has something wrong.

How to reproduce:

Round 1

* Open Sound Recorder, click "Record sound" button, say "This is the first record", then click "Stop sound"
* Click "Play sound", you can hear "This is the first sound"

Round 2

* Without clicking save button, click "Record sound" again, it will prompt you to save the sound, choose "Save As" to save it to "1.ogg"
* Now new record is started, say "This is the second record", then click "Stop sound"
* Click "Play sound" again, but you still hear "This is the first found", not the expected "This is the second record"

Round 3

* Click "Record sound" for the third time, after prompt save the second record to "2.ogg"
* Record the sound "This is the third record", then click "Stop sound"
* Click "Play sound" and you will hear "This is the second record", not "This is the third record"

....

So the play issue is fixed, but it will always play the last saved record instead of the current record after the second time.

Please help to reproduce.

[Sebastien Bacher (seb128)]

@Ding Zhou: right, that's why I described in comment #10, it's a bit confusing but still better than the error before so setting as verification-done, we can fix the confusion in a follow up SRU later

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-media - 3.4.0-0ubuntu2.1

---------------
gnome-media (3.4.0-0ubuntu2.1) precise-proposed; urgency=low

  * debian/patches/git_play_after_second_record.patch:
    - "Properly reinitialize when starting a new recording",
       should fix playing of records after the first saved one,
       thanks James M Leddy (lp: #1011436)
 -- Sebastien Bacher <email address hidden> Wed, 04 Jul 2012 18:01:35 +0200

[James M. Leddy (jm-leddy)]

The new bug is bug 1029092.