revert to previous focus box in Content Publish screen remains available after reverting

[Kit Blake]

If you revert to previous, it works fine, but the �revert to previous� focus box
in the Content Publish screen remains available after reverting. This is because
the action copies the published content into a yet newer version. Doing revert
to previous again has no effect. The danger here is that Authors may think they
can revert to previous/previous (older) versions, and that's not possible.

Really the action should delete the current new version. Then the published
content is the only content, the �revert to previous� focus box will dissappear,
and the Author must make a new version to continue.

[Martijn Faassen (faassen)]

I'm going to move this workflow related change over into the future.

[Andy Altepeter (aaltepet)]

With the addition of the "Manager versions" tool in the status tab, there is now no use of the 'revert_to_previous' macro in the Status tab of VersionedContent objects.

The code, however, is still there, in the macro and the action python script. These should be marked as deprecated and eventually removed. It is possible (although hopefully unlikely) that other VersionedContent objects not in the core are still using the revert to previous.

Kit, should this just be removed for 2.1, or marked as deprecated, and cleaned out later?

[Andy Altepeter (aaltepet)]

SilvaNewsNetwork has it's own tab_status_macros template. That will need to be cleaned up as well. It doesn't use revert_to_previous.

[Kit Blake (kitblake)]

I think we can remove it but we should add a note to the developers mail that goes out with major releases. Actually, we should have a place to aggregate those notes. We could put it in yet-another-text-file, or maybe somewhere on Launchpad?

[Andy Altepeter (aaltepet)]

Kit, I saw in silva-cvs that you removed the 'revert-to-previous' button? Is this the case, and should I cleanup the SNN tab_status_macros?

(If this change won't be released until Silva 2.1, then the change to SNN will have to wait until it's release for Silva 2.1.

[Kit Blake (kitblake)]

Yes, go ahead (I was planning on doing that myself next time I was in SNN). It's not in use so there's no reason to wait until Silva 2.1.

[Andy Altepeter (aaltepet)]

revert_to_previous macro has been removed, as well as the API has been cleaned up.

[Andy Altepeter (aaltepet)]

Kit, about this comment:
I think we can remove it but we should add a note to the developers mail that goes out with major releases. Actually, we should have a place to aggregate those notes. We could put it in yet-another-text-file, or maybe somewhere on Launchpad?

Launchpad could be used, in fact we could tag issues that need mention in developer_notes and the email to the silva-dev list. Or, we could just add all changes that developers should be informed about in developer_notes.txt...

[Kit Blake (kitblake)]

I like the idea of tagging issues on Launchpad, because then someone could find them all, as opposed to searching for the occasional mail to the dev list that accompanies a release. Of course, a text file would collect them all too, but I'd prefer not to add another text file.