Non-RSS Bookbag Feeds are Broken

Bug #1010036 reported by Dan Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned

Bug Description

-Evergreen 2.2-

Non-RSS feeds are currently causing an Apache internal server error. For instance (assuming a bookbag of ID #1), this works:

/opac/extras/feed/bookbag/rss2-full/1

while these do not:

/opac/extras/feed/bookbag/html-full/1 (default "view" link for JSPAC bookbags)
/opac/extras/feed/bookbag/mods-full/1
/opac/extras/feed/bookbag/atom-full/1
etc.

The problem seems to be a 'description' attribute added here:

http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9f273271093aa9226c5a27613bb5f7f1d3f0e7db

This attribute is only defined for the rss2 feed type, so the others die.

Possible solutions might be:

a) add a description method to the base Feed package - I am not sure if a useful general method exists, but I suppose it could be just a stub/placeholder

b) change SuperCat to only add the description to rss2 feeds - this assumes that description is not generally useful to other feed types, and I am not well-versed enough to answer that

Tags: pullrequest
Revision history for this message
Dan Wells (dbw2) wrote :

This branch implements solution 'a' (as set by precedent for other feed fields):

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1010036_feed_fix

tags: added: pullrequest
Revision history for this message
Mike Rylander (mrylander) wrote :

Committed to master and 2.2, for great justice!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.