Apostrophe's in names appear to error out the importer

Bug #1008788 reported by Mike Lindsay
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Enapps OpenERP CSV Import Tool
Fix Released
Undecided
Enapps Ltd OpenERP Partner London UK

Bug Description

I tried to import some suppliers, it errored out. Seems mainly tied to my suppliers having apostrophe's in the name. I tried making sure my CSV had all strings double quoted, that didn't seem to matter and still generated an error.
 Here is what my CSV data looked like when opened up with a text editor. Removing the apostrophe seemed to fix the error, but is not an ideal solution.
,"Vance's Foods, Inc.",

And here is the error message;
OpenERP Server Error
Client Traceback (most recent call last):
  File "/opt/openerp/server/openerp/addons/web/common/http.py", line 180, in dispatch
    response["result"] = method(controller, self, **self.params)
  File "/opt/openerp/server/openerp/addons/web/controllers/main.py", line 1004, in call_button
    action = self.call_common(req, model, method, args, domain_id, context_id)
  File "/opt/openerp/server/openerp/addons/web/controllers/main.py", line 948, in call_common
    return self._call_kw(req, model, method, args, {})
  File "/opt/openerp/server/openerp/addons/web/controllers/main.py", line 962, in _call_kw
    return getattr(req.session.model(model), method)(*args, **kwargs)
  File "/opt/openerp/server/openerp/addons/web/common/openerplib/main.py", line 250, in proxy
    args, kw)
  File "/opt/openerp/server/openerp/addons/web/common/openerplib/main.py", line 117, in proxy
    result = self.connector.send(self.service_name, method, *args)
  File "/opt/openerp/server/openerp/addons/web/common/http.py", line 611, in send
    raise fault

Server Traceback (most recent call last):
  File "/opt/openerp/server/openerp/addons/web/common/http.py", line 592, in send
    result = openerp.netsvc.dispatch_rpc(service_name, method, args)
  File "/opt/openerp/server/openerp/netsvc.py", line 360, in dispatch_rpc
    result = ExportService.getService(service_name).dispatch(method, params)
  File "/opt/openerp/server/openerp/service/web_services.py", line 572, in dispatch
    res = fn(db, uid, *params)
  File "/opt/openerp/server/openerp/osv/osv.py", line 167, in execute_kw
    return self.execute(db, uid, obj, method, *args, **kw or {})
  File "/opt/openerp/server/openerp/osv/osv.py", line 121, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/opt/openerp/server/openerp/osv/osv.py", line 176, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/opt/openerp/server/openerp/addons/audittrail/audittrail.py", line 495, in execute_cr
    return fct_src(cr, uid, model, method, *args)
  File "/opt/openerp/server/openerp/osv/osv.py", line 164, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/opt/openerp/server/openerp/addons/ea_import/ea_import_chain.py", line 81, in import_to_db
    result_id = chain_link.template_id.generate_record(record_list, context=context)
  File "/opt/openerp/server/openerp/osv/orm.py", line 368, in function_proxy
    return attr(self._cr, self._uid, [self._id], *args, **kwargs)
  File "/opt/openerp/server/openerp/addons/ea_import/ea_import_template.py", line 62, in generate_record
    updating_record_id = self.low_level_search(cr, uid, ids, upd_key, context=context)
  File "/opt/openerp/server/openerp/addons/ea_import/ea_import_template.py", line 108, in low_level_search
    %s""" % (target_model_pool._table, where_string))
  File "/opt/openerp/server/openerp/sql_db.py", line 152, in wrapper
    return f(self, *args, **kwargs)
  File "/opt/openerp/server/openerp/sql_db.py", line 212, in execute
    res = self._obj.execute(query, params)
ProgrammingError: syntax error at or near "s"
LINE 5: AND name = 'Vance's Foods'

Revision history for this message
Enapps Ltd OpenERP Partner London UK (enapps-london-uk) wrote :

cheers Mike, we'll have a look

Changed in enapps-csv-import-tool:
status: New → Confirmed
assignee: nobody → Enapps Ltd OpenERP Partner London UK (enapps-london-uk)
Revision history for this message
Paul Catinean (wiz-keed) wrote :

This also affects me and i was just about report it, seemed pretty suspicious when i first saw it, there should be some form of query string formatting i guess...

Revision history for this message
Lorenzo Battistini (elbati) wrote :

Hello,
I fixed it with attached patch

Revision history for this message
Enapps Ltd OpenERP Partner London UK (enapps-london-uk) wrote :
Changed in enapps-csv-import-tool:
status: Confirmed → Fix Released
Revision history for this message
Lorenzo Battistini (elbati) wrote :

Thanks :-)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.