Disabling "Default Tools" crashes Pinta

[grofaty]

Latest development on Ubuntu 12.04:
1. Edit | Add-in Manager.
2. Installed tab - click on rectangle at Core to expand tree.
3. Click on "Default Tools" to mark tools.
4. Click on Disable button and click on Close button.
5. Click on Tools pallet and Pinta crashes with error:
==========
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ArgumentOutOfRangeException: Argument is out of range.
Parameter name: index
  at System.Collections.Generic.List`1[Pinta.Core.BaseTool].get_Item (Int32 index) [0x00000] in <filename unknown>:0
  at Pinta.Core.ToolManager.get_CurrentTool () [0x00000] in <filename unknown>:0
  at Pinta.Gui.Widgets.PintaCanvas.<PintaCanvas>m__10 (System.Object sender, Gtk.MotionNotifyEventArgs e) [0x00000] in <filename unknown>:0
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0
  --- End of inner exception stack trace ---
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <filename unknown>:0
  at System.Delegate.DynamicInvokeImpl (System.Object[] args) [0x00000] in <filename unknown>:0
  at System.MulticastDelegate.DynamicInvokeImpl (System.Object[] args) [0x00000] in <filename unknown>:0
  at System.MulticastDelegate.DynamicInvokeImpl (System.Object[] args) [0x00000] in <filename unknown>:0
  at System.Delegate.DynamicInvoke (System.Object[] args) [0x00000] in <filename unknown>:0
  at GLib.Signal.ClosureInvokedCB (System.Object o, GLib.ClosureInvokedArgs args) [0x00000] in <filename unknown>:0
  at GLib.SignalClosure.Invoke (GLib.ClosureInvokedArgs args) [0x00000] in <filename unknown>:0
  at GLib.SignalClosure.MarshalCallback (IntPtr raw_closure, IntPtr return_val, UInt32 n_param_vals, IntPtr param_values, IntPtr invocation_hint, IntPtr marshal_data) [0x00000] in <filename unknown>:0
==========

Although disabling "Default Tools" at the moment (until maybe someone else develops some other useful tools) is not reasonable in my humble opinion, program should never crash.

[Robert Nordan (rpvn)]

This is ridiculous, I could have sworn that it worked fine when i pushed the changes, but now I'm getting the same error. Argh blargh rargh. I'll get right on it.

At least disabling the effects add-in isn't causing trouble.

[Robert Nordan (rpvn)]

Just pushed [1] which hopefully hardens the canvas and toolbox to avoid this problem and a similar problem when Pinta is started up without any tool add-ins enabled.

[1] https://github.com/PintaProject/Pinta/commit/c3ceda1d11070129820f81dea383d0c61a408b68

[grofaty (grofaty)]

Update to the latest development, tested and problem is fixed.