Keyboard Mapping for Auto DJ Functions (Vs. 1.11)

Bug #1006550 reported by harry lime
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
Scott Stewart

Bug Description

rryan asked me to add this to the bug reports. Not a bug as such but something that would be nice if included.

Here's what i wrote on the forum:

Is it possible to map the Auto DJ functions such as shuffle, skip track, fade now and most importantly the enable/disable button. I'd like to set these up on my keyboard (i've made some customizations already in conjunction with my midi controller) and just wondered, assuming it's possible, what the parameter titles were as they're not mentioned in the Wiki?

Related branches

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Wishlist
tags: added: easy weekend
Revision history for this message
harry lime (ub7-marcus) wrote :

Would also like to have included an "add to auto dj" parameter as a keyboard shortcut!

tags: added: autodj
Revision history for this message
harry lime (ub7-marcus) wrote :

thx for doing that so quickly!
where would i find a list of those tags, i'd like to test it out with the beta?

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Sorry Harry, those tags helps us finding this bug, not more :-(

Revision history for this message
harry lime (ub7-marcus) wrote :

ooops, totally misunderstood ...no worries!

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

We can do this for 1.11 as a 'maybe if someone has time' sort of thing. Also this should be pretty easy if any new contributors want to pick it up.

Changed in mixxx:
milestone: none → 1.11.0
Changed in mixxx:
assignee: nobody → Scott Stewart (smstewart91)
Revision history for this message
Scott Stewart (smstewart91) wrote :

Here is a patch. I added fade_now, skip_next, shuffle_playlist, and toggle_autodj to the [AutoDJ] group
Feedback and extra testing appreciated :)

Revision history for this message
Scott Stewart (smstewart91) wrote :

Just read back over the bug and realized that I missed "add to autodj". I will add that and post a patch back up

Revision history for this message
harry lime (ub7-marcus) wrote :

I will be happy to try this out once you've got the new patch ready

Changed in mixxx:
status: Confirmed → In Progress
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Hi Scott,

thank you for your patch!

Here are my comments:
* Please make sure your code full fills http://www.mixxx.org/wiki/doku.php/coding_guidelines. There are many places in Mixxx with different style, but the target is to have a unified code base.
* Please set your editors, including meld for using 4 spaces instead of a single tab.
* Please delete your new pushbuttons in the Class destructor
* The QT ui GUI button are bypassing the Control objects. This will work for a quick fix like this, but it breaks a little bit the concept of control objects. I am not sure if this matters for 1.11.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hi Scott -- any update on this patch? It'd be nice to get it into Mixxx 1.11.0

Revision history for this message
Scott Stewart (smstewart91) wrote : Re: [Bug 1006550] Re: Keyboard Mapping for Auto DJ Functions (Vs. 1.11)

Hi RJ,
I found a good solution while working on other stuff, so I'll be updating
the patch by the end of the week.

Scott
On Jul 10, 2012 7:46 AM, "RJ Ryan" <email address hidden> wrote:

> Hi Scott -- any update on this patch? It'd be nice to get it into Mixxx
> 1.11.0
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1006550
>
> Title:
> Keyboard Mapping for Auto DJ Functions (Vs. 1.11)
>
> Status in Mixxx:
> In Progress
>
> Bug description:
> rryan asked me to add this to the bug reports. Not a bug as such but
> something that would be nice if included.
>
> Here's what i wrote on the forum:
>
> Is it possible to map the Auto DJ functions such as shuffle, skip
> track, fade now and most importantly the enable/disable button. I'd
> like to set these up on my keyboard (i've made some customizations
> already in conjunction with my midi controller) and just wondered,
> assuming it's possible, what the parameter titles were as they're not
> mentioned in the Wiki?
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1006550/+subscriptions
>

Revision history for this message
Scott Stewart (smstewart91) wrote :

Here is an updated patch that updates the ControlObjects. I couldn't find a way to turn "add selected track" into a mappable function, so if anyone has ideas for that one, please share

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks Scott -- I reworked the toggle one a little bit so that the ControlPushButton is a push and not a toggle button (making it a toggle stores the state in the CO while the Qt push button also stores the state by virtue of its 'checked' property). Committed to lp:mixxx/1.11 r3322.

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6491

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.