Setting loop's end before loop's start is allowed and break the loop control

[Thomas Vincent]

On overview set loop's end.
Set cursor after the current position on overview.
Set loop's start.

-> broken loop is created and unusable.

 What should be the expected behaviour ?
1) adding start after the end does nothing (like it does when setting end before start) but the work-flow is kind of broken ... to unstuck the situation we need to creates a pre-sized loop or worse go at the end of the track then set the loop's end then set the start when we really want ...)
2) set start and end of the last clicked point resulting in a null size loop letting the user the possibility to set the end afterwards from this position

[RJ Skerry-Ryan (rryan)]

Hm -- we have a bunch of range checks on this sort of thing but we must have missed a case.

[RJ Skerry-Ryan (rryan)]

The functionality today is that if you attempt to place the loop start position after the end position then the end position is cleared (set to -1) so it's as if there is no end position. Once the user hits the 'loop out' button it will place an end position and the new loop will become active.

Preventing positioning the start after the end will break this case:

1) User sets a loop.
2) Breaks the loop by hitting Reloop/Exit. Loop start/end point are still where they were but it's deactivated.
3) Play head passes the end of the loop.
4) User wants to lay a new start/end of the loop so hits 'loop in'.

If we cancelled this action then it would interrupt the user's attempt to place the start point of a new loop.

[RJ Skerry-Ryan (rryan)]

Any comments Thomas? I may have misunderstood you.

[RJ Skerry-Ryan (rryan)]

Jus -- you marked it confirmed. Can you describe how to reproduce? I'm not sure I understand from Thomas's description.

[RJ Skerry-Ryan (rryan)]

Tentatively marking fixed. Please re-open if you see it again.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6489