security group handler doesn't get called with QuantumManger

Bug #1005990 reported by Tomoe Sugihara
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Davanum Srinivas (DIMS)

Bug Description

QuantumManager overrides allocate_for_instance and doesn't call security groups handler (tried with tip of Essex branch).

In NetworkManager.allocate_fixed_ip() (via allocate_for_instance) , it calls self._do_trigger_security_group_members_refresh_for_instance() which ultimately calls sgh.trigger_security_group_members_refresh(). But it is overridden by QuantumManager and doesn't get called.

I tried the following and confirmed that triggered the callback method.

------------------------
diff --git a/nova/network/quantum/manager.py b/nova/network/quantum/manager.py
index 498b5f0..ebf4890 100644
--- a/nova/network/quantum/manager.py
+++ b/nova/network/quantum/manager.py
@@ -372,6 +372,10 @@ class QuantumManager(manager.FloatingIP, manager.FlatManage
             if FLAGS.quantum_use_dhcp:
                 self.enable_dhcp(context, network['quantum_net_id'], network,
                     vif_rec, network['net_tenant_id'])
+
+ self._do_trigger_security_group_members_refresh_for_instance(
+ instance_id)
+
         return self.get_instance_nw_info(context, instance_id,
                                          instance['uuid'],
                                          rxtx_factor, host,
--------------------------

Thierry Carrez (ttx)
tags: added: quantum-manager
removed: quantum
Changed in nova:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :
Changed in nova:
status: Triaged → Fix Committed
assignee: nobody → Davanum Srinivas (dims-v)
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.