The default config values in nova.conf.sample contain quotes where there shouldn't be any

Bug #1005869 reported by Derek Higgins
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Derek Higgins

Bug Description

For values of type StrOpt, ListOpt and MultiStrOpt the default config values in nova.conf.sample are surrounded by quotes
e.g.
# default_log_levels="amqplib=WARN,sqlalchemy=WARN,boto=WARN,suds=INFO,eventlet.wsgi.server=WARN"

if uncommented results in a value of
['"amqplib=WARN', 'sqlalchemy=WARN', 'boto=WARN', 'suds=INFO', 'eventlet.wsgi.server=WARN"']

it should be
['amqplib=WARN', 'sqlalchemy=WARN', 'boto=WARN', 'suds=INFO', 'eventlet.wsgi.server=WARN']

I think the quotes should be removed from the config file and tools/conf/create_conf.py changed not to include them

Tags: docimpact
Derek Higgins (derekh)
Changed in nova:
assignee: nobody → Derek Higgins (derekh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7872

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/7872
Committed: http://github.com/openstack/nova/commit/d5f888fc7ad8b83b8af25c96c0211b0d70405c89
Submitter: Jenkins
Branch: master

commit d5f888fc7ad8b83b8af25c96c0211b0d70405c89
Author: Derek Higgins <email address hidden>
Date: Thu May 31 11:22:25 2012 +0100

    Removing double quotes from sample config file

    Fixes bug #1005869

    Changing create_conf.py to no longer include quotes for
    StrOpt, ListOpt and MultiStrOpt types, Also regenerating
    and new version of etc/nova/nova.conf.sample

    Change-Id: I31c0a6cdcfd3e7cacaae6afbf75648ef0a34d668

Changed in nova:
status: In Progress → Fix Committed
tags: added: docimpact
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.