pcb

Build fails when DEBUG constant defined.

Bug #1005137 reported by Jeff Mallatt
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
pcb
Fix Released
Low
Bert Timmerman

Bug Description

I used the following to configure for a debug build with the DEBUG constant defined:

CFLAGS=-DDEBUG=1 ./configure --prefix=$HOME/inst/pcb --disable-gl --enable-debug

After that, a "make" failed with a few compile errors. I made the following minimal changes to get the compiles to work:

boolean.c -- Disabled the compilation of unused functions by changing "#ifdef DEBUG"s to "#ifdef DEBUG_UNUSED"s.

edif.y -- Fixed a forward reference problem by moving definitions of "Parser state variables" to just before a function referencing some of them. Also updated some old defined constant names.

gcode.c -- Added "#include <locale.h>".

Revision history for this message
Jeff Mallatt (jjm-j) wrote :

After many changes to gcode.c, make sure this patch still applies.

New patch against latest repository attached.

Revision history for this message
Jeff Mallatt (jjm-j) wrote :

While checking to make sure the patch still applied, I noticed that some
lines I changed in edif.y contained whitespace errors in the original
file, hence the patch contained them. I have changed the patch to include
fixing these whitespace errors.

New patch against latest repository attached.

Traumflug (mah-jump-ing)
Changed in geda-project:
importance: Undecided → Medium
Revision history for this message
Chad Parker (parker-charles) wrote :

This bug has changed a little bit since 2012. The only problem is now in edif.y. A couple of definitions need to be moved forward, and there were some symbols that didn't get prefixed at some point.

I reported this bug on the mailing list a few months back.

I've pushed a fix to git: home/cparker/LP1005137

Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

Hi Chad,

Merged and pushed to master.

Thanks and kind regards,

Bert Timmerman.

Changed in pcb:
importance: Undecided → Low
status: New → Fix Committed
assignee: nobody → Bert Timmerman (bert-timmerman)
milestone: none → next-bug-release
Changed in pcb:
status: Fix Committed → Fix Released
Revision history for this message
Chad Parker (parker-charles) wrote :

Fixed in 4.0.0

Changed in geda-project:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.