Add Mixxx version tags in skins

[RJ Skerry-Ryan]

We should make sure we are forward compatible.. specifically people have run into trouble with eq-kills (due to powerwindow) and I think beatloop_x_activate.

[Daniel Schürmann (daschuer)]

I think we should introduce a version tag

<Version>
    <MinimumMixxx>1.11.0</MinimumMixxx>
    <Skin>05</Skin>
</Version>

[Daniel Schürmann (daschuer)]

Hi RJ, Hi Skin designer, Hi Controller Guys,

my original power window button patch introduces a decoupling from the midi buttons and the GUI buttons.
I not sure if this was actually working but we should consider it again because of this bug.

See Bug #876139 and RJs comments in #11

For my feeling it is a good idea to let the skin designer decide a bout the GUI buttons behavior and the midi script writer (controller manufacturer) decide about the midi button behavior.

Mixxx itself should be as much tolerant as possible, to allow different button styles for the same control.

(I am afraid this software design a ideal case and not entirely possible, but we give a try)

I the end the end we can achieve that Mixxx 1.11 works with 1.10 skins like 1.10 does. The same might be possible for midi scrips.

What do you think?

Kind regards,

Daniel

[RJ Skerry-Ryan (rryan)]

I think I failed to do this... oops :(.

[Sean M. Pappalardo (pegasus-renegadetech)]

Updating for 1.12 since this is still a good idea.

[Sean M. Pappalardo (pegasus-renegadetech)]

We should add a <MixxxVersion> tag just like we have in controller presets (and assume 1.11 for ones with no tag) and add something to the tests to list the skins that have no or an old version tag so we're reminded to check them for forward-compatibility.

[Owen Williams (ywwg)]

skins already have <manifest> <version>1.12.0.01</version> -- is this not enough?

[RJ Skerry-Ryan (rryan)]

Version is the skin version, not the mixxx version (it's unused currently but I'd like to show it in a skin picker UI in the future).

Having a min Mixxx version tag in the manifest is probably worth doing. Unfortunately 1.11 won't be able to recognize that it can't read a skin but that way 1.12.0 will be able to tell that it can't read future skin versions that are incompatible.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6481