exhibits pkgname with \n\r

Bug #1004417 reported by Michael Vogt
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Software Center Agent
Fix Released
Low
Unassigned
software-center (Ubuntu)
Fix Released
Medium
Unassigned
Precise
Fix Released
Undecided
Unassigned

Bug Description

The server sends out funny packagenames for the ubuntu books:

...
        "package_names": "ubuntu-unleashed-2012,ubuntu-unleashed-2011,ubuntu-practical-guide,ubuntu-server-book,official-ubuntu-book\r\n",
...

note the \r\n in there.

SRU TEST CASE:
1. Launch the current Ubuntu Software Center in Precise.
2. Wait for the "Definitive Guides to Ubuntu" banner to be shown (or use the banner navigation buttons to access it). Click on the banner to access the list of titles.
3. Note that there are a total of four (4) titles in the list.
4. Close Ubuntu Software Center.
5. Update to the version of software-center in precise-proposed.
6. Launch Ubuntu Software Center again and click on the "Definitive Guides to Ubuntu" banner again.
7. Verify that this time there are five (5) items in the list.

SRU REGRESSION POTENTIAL:
Risk of regression is extremely small. Fix simply removes white space from the package names field from the server.

Related branches

Revision history for this message
Michael Vogt (mvo) wrote :

The attached branch fixes it in the client, but it would be preferable to do it on the server IMO.

Michael Vogt (mvo)
Changed in software-center-agent:
status: New → In Progress
importance: Undecided → Low
Revision history for this message
Michael Vogt (mvo) wrote :

This should probably also get fixed on the client because the next server deployment will take some time:
<achuni> mvo: if not, most likely in ~10 days with the next finance integration fixes

Michael Vogt (mvo)
Changed in software-center (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
Changed in software-center (Ubuntu):
status: In Progress → Fix Committed
description: updated
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted software-center into precise-proposed. The package will build now and be available in a few hours. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in software-center (Ubuntu Precise):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Gary Lasker (gary-lasker) wrote :

I have verified that software-center version 5.2.3 in precise-proposed fixes this bug per the test case given in the description.

Thanks!

tags: added: verification-done
removed: verification-needed
Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 5.2.3

---------------
software-center (5.2.3) precise-proposed; urgency=low

  [ Robert Roth ]
  * lp:~evfool/software-center/lp987801:
    - Only show the version label once for each version in
      reviews (LP: #987801)
  * lp:~evfool/software-center/lp874430:
    - display tooltips for package titles in the application
      tiles of the lobby view (LP: #874430)
  * lp:~evfool/software-center/lp983831:
    - Avoid merging two words while normalizing description (LP: #983831)
  * lp:~evfool/software-center/lp822625:
    - Set default value for reviewstats histogram (LP: #822625)
  * lp:~evfool/software-center/lp875874:
    - Set word wrap with fallback to char wrapping for the review
      text label (LP: #875874)

  [ Gabor Kelemen ]
  * lp:~kelemeng/software-center/bug1001746:
    - merge i18n fix (LP: #1001746)

  [ Michael Vogt ]
  * lp:~mvo/software-center/lp872760-for-5.2:
    - fix translations for certain category names (LP: #872760)
  * lp:~mvo/software-center/lp987321:
    - fix dependency to ensure that we have humanity-icon-theme
      as we need it for the history view icons (LP: #987321)
  * lp:~mvo/software-center/test-catview-cleanup:
    - refactor unit tests for the catview
  * lp:~mvo/software-center/lp1002271:
    - fix regresion in 5.2.2 (LP: #1002271) for empty descriptions
  * lp:~mvo/software-center/lp1005104:
    - fix regression in 5.2.2 (LP: #1005104) in initial navigation
      history
  * lp:~mvo/software-center/client-lp1004417:
    - client side fix for when exhibit package names contain
      extra whitespace (LP: #1004417)

  [ Gary Lasker ]
  * lp:~gary-lasker/software-center/fix-crash-lp1000238:
    - remove obsolete workaround for an old bug that has long since
      been fixed, this fixes a hard crash on Quantal (LP: #1000238)
  * lp:~gary-lasker/software-center/toolbar-buttons-insensitive-during-startup:
    - re-enable the fix for LP: #999486, LP: #994341 that was inadvertently
      disabled in the 5.2.2 release

  [ Natalia Bidart ]
  * lp:~nataliabidart/software-center/fix-977931:
    - Unified package string parsing into a single method that will be
      used from either the command line arguments, or from the dbus method
      'bringToFront'. This way, search will be consistent between all
      entry points. LP: #977931
    - Also added proper test suites for the above.
  * lp:~nataliabidart/software-center/fix-965093:
    - Fixed the SpinnerNtebook show_spinner method so the spinner page is
      not shown until the configured threshold is reached (250ms since
      this branch). Plus proper test suite was added.
  * lp:~nataliabidart/software-center/fix-986563:
    - Filtered out those exhibits that do not their packages available
      in the db (LP: #986563)
 -- Michael Vogt <email address hidden> Mon, 04 Jun 2012 08:53:25 +0200

Changed in software-center (Ubuntu Precise):
status: Fix Committed → Fix Released
Changed in software-center-agent:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.