Admin module cannot load in 0.9.10-pre2

[Steve Keller]

Running 0.9.10-pre2, and upon loading the admin module, I see this on the web page:

Looks to me as if the simplejson module is being referenced, and I am running Python 2.7.3, which shouldn't need this.

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python2.7/site-packages/django/contrib/admin/sites.py", line 214, in wrapper
    return self.admin_view(view, cacheable)(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/utils/decorators.py", line 93, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/decorators/cache.py", line 79, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/contrib/admin/sites.py", line 197, in inner
    return view(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/decorators/cache.py", line 79, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/contrib/admin/sites.py", line 382, in index
    context_instance=context_instance
  File "/usr/lib/python2.7/site-packages/django/shortcuts/__init__.py", line 20, in render_to_response
    return HttpResponse(loader.render_to_string(*args, **kwargs), **httpresponse_kwargs)
  File "/usr/lib/python2.7/site-packages/django/template/loader.py", line 188, in render_to_string
    return t.render(context_instance)
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 123, in render
    return self._render(context)
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 117, in _render
    return self.nodelist.render(context)
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 744, in render
    bits.append(self.render_node(node, context))
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 757, in render_node
    return node.render(context)
  File "/usr/lib/python2.7/site-packages/django/template/loader_tags.py", line 127, in render
    return compiled_parent._render(context)
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 117, in _render
    return self.nodelist.render(context)
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 744, in render
    bits.append(self.render_node(node, context))
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 757, in render_node
    return node.render(context)
  File "/usr/lib/python2.7/site-packages/django/template/loader_tags.py", line 127, in render
    return compiled_parent._render(context)
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 117, in _render
    return self.nodelist.render(context)
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 744, in render
    bits.append(self.render_node(node, context))
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 757, in render_node
    return node.render(context)
  File "/usr/lib/python2.7/site-packages/django/template/defaulttags.py", line 311, in render
    return self.nodelist_true.render(context)
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 744, in render
    bits.append(self.render_node(node, context))
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 757, in render_node
    return node.render(context)
  File "/usr/lib/python2.7/site-packages/django/template/defaulttags.py", line 311, in render
    return self.nodelist_true.render(context)
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 744, in render
    bits.append(self.render_node(node, context))
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 757, in render_node
    return node.render(context)
  File "/usr/lib/python2.7/site-packages/django/template/loader_tags.py", line 64, in render
    result = block.nodelist.render(context)
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 744, in render
    bits.append(self.render_node(node, context))
  File "/usr/lib/python2.7/site-packages/django/template/base.py", line 757, in render_node
    return node.render(context)
  File "/usr/lib/python2.7/site-packages/django/template/defaulttags.py", line 437, in render
    url = reverse(view_name, args=args, kwargs=kwargs, current_app=context.current_app)
  File "/usr/lib/python2.7/site-packages/django/core/urlresolvers.py", line 391, in reverse
    *args, **kwargs)))
  File "/usr/lib/python2.7/site-packages/django/core/urlresolvers.py", line 312, in reverse
    possibilities = self.reverse_dict.getlist(lookup_view)
  File "/usr/lib/python2.7/site-packages/django/core/urlresolvers.py", line 229, in _get_reverse_dict
    self._populate()
  File "/usr/lib/python2.7/site-packages/django/core/urlresolvers.py", line 208, in _populate
    for name in pattern.reverse_dict:
  File "/usr/lib/python2.7/site-packages/django/core/urlresolvers.py", line 229, in _get_reverse_dict
    self._populate()
  File "/usr/lib/python2.7/site-packages/django/core/urlresolvers.py", line 220, in _populate
    lookups.appendlist(pattern.callback, (bits, p_pattern))
  File "/usr/lib/python2.7/site-packages/django/core/urlresolvers.py", line 167, in _get_callback
    raise ViewDoesNotExist("Could not import %s. Error was: %s" % (mod_name, str(e)))
ViewDoesNotExist: Could not import graphite.events.views. Error was: No module named simplejson

[Michael Leinartas (mleinartas)]

Fix committed to master. Simplejson should only be tried if the 'json' module cant be loaded

[Steve Keller (skeller-ea)]

I looked at the fix of this bug, unfortunately it is incomplete. It does fix the import error, but someone needs to regularize the use of simplejson vs. json. The fix does this:

try:
  import json
except ImportError:
  import simplejson as json

Unfortunately, later in the same file this appears:

    return HttpResponse(simplejson.dumps(result), mimetype="application/json")

This same situation appears in graphite.graphlot.views as well.

[Michael Leinartas (mleinartas)]

Oh jeez, definitely that was rushed without testing. I've gone through and changed the references properly and switched things to use the wrapped import in graphite.util.json which handles the try/except importing.

Thanks for following up and checking the work. This is now pushed to master

[bhardy (bhardy)]

I will be out of the office and unreachable on 6/7 and 6/8. I will return to the office on 6/11.

Please reach out to the ESM team for any concerns. Thanks.

--Bryant

On May 25, 2012, at 5:58 PM, Michael Leinartas <email address hidden> wrote:

> Oh jeez, definitely that was rushed without testing. I've gone through
> and changed the references properly and switched things to use the
> wrapped import in graphite.util.json which handles the try/except
> importing.
>
> Thanks for following up and checking the work. This is now pushed to
> master
>
> --
> You received this bug notification because you are subscribed to
> Graphite.
> https://bugs.launchpad.net/bugs/1003073
>
> Title:
>  Admin module cannot load in 0.9.10-pre2
>
> Status in Graphite - Enterprise scalable realtime graphing:
>  Fix Committed
>
> Bug description:
>  Running 0.9.10-pre2, and upon loading the admin module, I see this on
>  the web page:
>
>  Looks to me as if the simplejson module is being referenced, and I am
>  running Python 2.7.3, which shouldn't need this.
>
>  Traceback (most recent call last):
>    File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 111, in get_response
>      response = callback(request, *callback_args, **callback_kwargs)
>    File "/usr/lib/python2.7/site-packages/django/contrib/admin/sites.py", line 214, in wrapper
>      return self.admin_view(view, cacheable)(*args, **kwargs)
>    File "/usr/lib/python2.7/site-packages/django/utils/decorators.py", line 93, in _wrapped_view
>      response = view_func(request, *args, **kwargs)
>    File "/usr/lib/python2.7/site-packages/django/views/decorators/cache.py", line 79, in _wrapped_view_func
>      response = view_func(request, *args, **kwargs)
>    File "/usr/lib/python2.7/site-packages/django/contrib/admin/sites.py", line 197, in inner
>      return view(request, *args, **kwargs)
>    File "/usr/lib/python2.7/site-packages/django/views/decorators/cache.py", line 79, in _wrapped_view_func
>      response = view_func(request, *args, **kwargs)
>    File "/usr/lib/python2.7/site-packages/django/contrib/admin/sites.py", line 382, in index
>      context_instance=context_instance
>    File "/usr/lib/python2.7/site-packages/django/shortcuts/__init__.py", line 20, in render_to_response
>      return HttpResponse(loader.render_to_string(*args, **kwargs), **httpresponse_kwargs)
>    File "/usr/lib/python2.7/site-packages/django/template/loader.py", line 188, in render_to_string
>      return t.render(context_instance)
>    File "/usr/lib/python2.7/site-packages/django/template/base.py", line 123, in render
>      return self._render(context)
>    File "/usr/lib/python2.7/site-packages/django/template/base.py", line 117, in _render
>      return self.nodelist.render(context)
>    File "/usr/lib/python2.7/site-packages/django/template/base.py", line 744, in render
>      bits.append(self.render_node(node, context))
>    File "/usr/lib/python2.7/site-packages/django/template/base.py", line 757, in render_node
>      return node.render(context)
>    File "/usr/lib/python2.7/site-packages/django/template/loader_tags.py", line 127, in render
>      return compiled_parent....