Add support for creating Windows x64 installer

Bug #1003041 reported by Teemu Nätkinniemi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Stellarium
Fix Released
Medium
Teemu Nätkinniemi

Bug Description

Not exactly a bug but I decided to add InnoSetup support for x64 Windows builds. Patch attached.

Related branches

Revision history for this message
Teemu Nätkinniemi (tnatkinn) wrote :
Revision history for this message
Teemu Nätkinniemi (tnatkinn) wrote :

Disregard, this one picks binaries from x86 Program Files

Changed in stellarium:
milestone: none → 0.11.4
Revision history for this message
Teemu Nätkinniemi (tnatkinn) wrote :

Here's a revised patch that picks correct binaries from the build directory rather than the install directory. This affects both 32-bit and 64-bit builds.

Revision history for this message
Alexander Wolf (alexwolf) wrote :

Why used @CMAKE_BINARY_DIR@ instead @CMAKE_INSTALL_PREFIX@ for \share\stellarium\ folder?

Changed in stellarium:
assignee: nobody → Teemu Nätkinniemi (tnatkinn)
status: New → In Progress
Revision history for this message
Teemu Nätkinniemi (tnatkinn) wrote :

This way when creating a new installer it uses binaries from the current build directory rather than the install directory (C:\Program Files (x86)) for 64-bit builds this is absolutely necessary, otherwise the installer might contain 32-bit binaries instead of 64-bit. This is because cmake does not support 64-bit Windows properly.

Revision history for this message
Alexander Wolf (alexwolf) wrote :
Changed in stellarium:
status: In Progress → Fix Committed
Revision history for this message
Bogdan Marinov (daggerstab) wrote :

I've merged the separate 64-bit version of the Inno Setup template, as it made maintenance more difficult:
http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/5441
Could you please test if the new version works correctly?

Please also note that before you run "make install", you are supposed to set CMAKE_INSTALL_PREFIX to some temporary directory. On Windows, it defaults to Program Files, but it's not supposed to work like that. So, before "make install", run CMake with something like:

cmake -DCMAKE_INSTALL_PREFIX=c:\stellarium-temp\

See also this unfinished draft in the Stellarium Wiki for how to do this from Qt Creator:
http://www.stellarium.org/wiki/index.php/User:Daggerstab/Building_Stellarium_on_Windows_with_Qt_Creator

Revision history for this message
Alexander Wolf (alexwolf) wrote :

Revision 5441 broke 64-bit buildings but I work under fix it. See LP bug #1027607

Changed in stellarium:
status: Fix Committed → Fix Released
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.