Validation for List servers by Flavor - expected error responses not returned

[Rohit Karajgi]

Our tempest tests run the following validation test for List Servers "by Flavor" API and fail
as the expected error codes are not returned.

1. test_list_servers_by_flavor_pass_negative_value - Return an error while listing server with negative flavor

Expected Error Code - 400 BadRequest
Actual Code - 200 OK

2. test_list_servers_by_flavor_pass_overlimit_flavor - Return an error while listing server with too large flavor value

Expected Error Code - 413 Overlimit
Actual Code - 200 OK

3. test_list_servers_by_non_existing_flavor - Return an error while listing server by non existing flavor

Expected Error Code - 404 NotFound
Actual Code - 200 OK

The List Servers API for listing by flavor should send the Expected error responses as above.

[Brian Waldon (bcwaldon)]

See https://bugs.launchpad.net/nova/+bug/1008456

[Rajalakshmi Ganesan (rajalakshmi-ganesan)]

Hi Waldon,

The case when we filter with Flavors is different from the one that happen when we filter with invalid image ID's. Hence I feel the argument in Bug 1008456 would not suffice.

Though flavor is compltele invalid/nonexistant, 200 OK is returned. It silently returna an empty list for invalid/nonexistant flavor ID.

Request you to clarify whether is behaviour is expected.

-Thanks in advance

[Russell Bryant (russellb)]

I updated this too quickly ... after looking at this more and reading the linked bug, I think the responses received are reasonable.