Mixxx

SoundManager Prevents Multiple AudioInput Registrations

Bug #1002496 reported by Matthew Mikolay on 2012-05-21

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mixxx	Fix Released	Low	Matthew Mikolay	Mixxx 2.0.0 "1.12.0"

Bug Description

The current implementation of the SoundManager class prevents multiple engines from registering with one specific AudioInput signal. For example, if I wanted to register an AudioInput signal corresponding to the turntable inputs with both the VinylControlManager and another different engine, the SoundManager would *not* report an error, but the functionality would only allow for the registration of one engine. The attached patch is the output of diff for a modification of the SoundManager class to allow multiple engines to register with a given AudioInput.

Revision history for this message

Matthew Mikolay (mattmik) wrote on 2012-05-21:

Output for diff command on modified SoundManager class Edit (1.3 KiB, text/plain)

Changed in mixxx:
assignee:	nobody → Matthew Mikolay (mattmik)

Revision history for this message

Owen Williams (ywwg) wrote on 2012-05-22:

Hey Matt, can you repost your diff using the -u option (unified diff)? It's easier to read that way.

Revision history for this message

Matthew Mikolay (mattmik) wrote on 2012-05-22:

Unified diff for modified SoundManager Edit (2.3 KiB, text/plain)

I've attached a unified diff (diff -u) of the same file uploaded before.

Revision history for this message

William Good (bkgood) wrote on 2012-06-04:

This looks safe to me, I'll try to get it committed in the next few days. My CPU heatsink fell off in transit and I haven't been able to find a good replacement yet :/.

RJ Skerry-Ryan (rryan) on 2013-05-10