builds are posted to lava even if images failed to transfer/publish

[Fathi Boudra]

See https://android-build.linaro.org/jenkins/job/linaro-android_vexpress-ics-gcc47-armlt-tracking-open-12.05-release/4/console

The build is posted to LAVA before the images are published to snapshots.
For various reasons, the publishing could fail.

[Paul Sokolovsky (pfalcon)]

All I can see there is:

Build timed out (after 170 minutes). Marking the build as aborted.
SSH: Disconnecting configuration [snapshots.linaro.org new] ...
ERROR: Exception when publishing, exception message [java.io.IOException]

Failed to create the target path /srv/snapshots.linaro.org/www/android/~linaro-android/vexpress-ics-gcc47-armlt-tracking-open-12.05-release/4 : [Errno 13] Permission denied: '/srv/snapshots.linaro.org/www/android/~linaro-android/vexpress-ics-gcc47-armlt-tracking-open-12.05-release/4'
Move Failed

Otherwise, we vice-versa have rather involved (and possibly not too reliable/hard to maintain) procedure to make sure we publish artifacts before submitting request to LAVA - that process alone takes 4 build steps.

[Fathi Boudra (fboudra)]

As discussed on IRC, bug re-titled to clarify.

On the log, we see:
1. transfer build files
2. reshuffle build files
3. post build to lava
4. transfer lava job info file
5. reshuffle lava job info file

steps 1/2 are mandatory to get 3/4/5 valid.

[Paul Sokolovsky (pfalcon)]

To clarify a bit more, if there was an error in steps 1/2 above (in the quoted build log we had global build timeout during transfer), the LAVA submission should not happen, while it happens now (i.e. further build steps continue to be executed, even though previous failed, which is weird).

[Paul Sokolovsky (pfalcon)]

There's a "Fail the build" checkbox for build timeout plugin configuration, but its help reads:

If checked, the build will be marked as failed rather than marked as aborted.
(In any case, the build does not continue when timeout is reached).

So, the build shouldn't continue once timeout hits, and it doesn't, if timeout happens during compilation. But it does continue if timeout hits during SFTP transfer. SSH plugin to blame? Maybe we should try that option anyway.

[Chase Qi (chase-qi)]

Migrated to bugzilla: https://bugs.linaro.org/show_bug.cgi?id=545