put center followed by text highlighting broken

[Gareth Bailey]

After using put center, when trying to highlight text in a terminal the cursor selects the wrong text. That is the cursor selects text from a position offset in the x-axis.

[Gareth Bailey (garethbailey0)]

The offending piece of code is the configureXWindow call in the 'center check'. I'm no X expert but I think you need to wait for a ChangeNotify before calling configureXWindow a second time.

However, I tried moveing this center check to the handleEvent method and doing the check on the changeNotify but the problem persisted so that's that theory out. Any ideas?

Also the center check doesn't actually work (for me), so we may as well just remove this peice of code if we can find no better place for it? (i.e. somewhere where it works and doesn't break anything else!)

[Gareth Bailey (garethbailey0)]

In the above I'm refering to this piece of code.

 if (centerCheck)
 {
     if ((cw->serverBorderRect ().width () >
   desiredSlot.width ()) ||
   cw->serverBorderRect ().width () <
   desiredSlot.width ())
     {
  wc.x = (workarea.width () >> 1) -
        ((cw->serverBorderRect ().width () >> 1) -
   cw->border ().left);
  cw->configureXWindow (CWX, &wc);
     }

     centerCheck = false;
 }
    }