Branch to colocated location fails: ValueError: need more than 1 value to unpack

[Neil Martinsen-Burrell]

I wanted to start testing the new colocated branches implementation in hopes of making bzr-colo work transparently with it. But, the first command I tried failed with a traceback:

$ bzr init --development-colo test
$ cd test
$ bzr branch file:///Users/nmb/tmp/test,new
bzr: ERROR: exceptions.ValueError: need more than 1 value to unpack

Traceback (most recent call last):
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/commands.py", line 923, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/commands.py", line 1128, in run_bzr
    ret = run(*run_argv)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/commands.py", line 676, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/commands.py", line 698, in run
    return self._operation.run_simple(*args, **kwargs)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/cleanup.py", line 135, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/cleanup.py", line 165, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/builtins.py", line 1297, in run
    from_location)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/controldir.py", line 749, in open_tree_or_branch
    controldir = klass.open(location)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/controldir.py", line 659, in open
    t = _mod_transport.get_transport(base, possible_transports)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/transport/__init__.py", line 1644, in get_transport
    return get_transport_from_url(location_to_url(base), possible_transports)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/transport/__init__.py", line 1619, in get_transport_from_url
    transport, last_err = _try_transport_factories(url, factory_list)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/transport/__init__.py", line 1651, in _try_transport_factories
    return factory.get_obj()(base), None
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/transport/local.py", line 73, in __init__
    super(LocalTransport, self).__init__(base)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/transport/__init__.py", line 313, in __init__
    self._segment_parameters = urlutils.split_segment_parameters(base)[1]
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/urlutils.py", line 460, in split_segment_parameters
    (key, value) = subsegment.split("=", 1)
ValueError: need more than 1 value to unpack

bzr 2.5.0dev4 on python 2.7.2 (Darwin-11.2.0-x86_64-i386-64bit)
arguments: ['/Users/nmb/usr/bin/bzr', 'branch', 'file:///Users/nmb/tmp,new']
plugins: automirror[0.1.0], bash_completion[2.5.0dev4],
    changelog_merge[2.5.0dev4], colo[0.3.1dev], launchpad[2.5.0dev4],
    netrc_credential_store[2.5.0dev4], news_merge[2.5.0dev4], qbzr[0.22.0dev],
    weave_fmt[2.5.0dev4]
encoding: 'UTF-8', fsenc: 'utf-8', lang: 'en_US.UTF-8'

This may not be the right way to create a colocated workspace in the new regime, but it certainly shouldn't fail like this.

[Martin Pool (mbp)]

This looks a bit like something jelmer just changed...

  status confirmed
  importance medium

[Jelmer Vernooij (jelmer)]

You need file://path/to/something,branch=bar

Though clearly we shouldn't blow up if there is a missing "=" in a path segment parameter.