CommitBuilder.record_entry_contents needs to die
Bug #731433 reported by
Jelmer Vernooij
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Confirmed
|
Low
|
Unassigned | ||
| Breezy |
Fix Released
|
Medium
|
Jelmer Vernooij | ||
Bug Description
CommitBuilder currently provides two interfaces to record tree changes, both of which are used by bzrlib.commit depending on the situation.
CommitBuilder.
Having two implementations is problematic since it makes requires duplicate effort for every CommitBuilder implementation and makes it harder to write tests.
Related branches
lp:~jelmer/brz/iter-changes-all-the-way
- Martin Packman: Approve
-
Diff: 356 lines (+14/-247)4 files modifiedbreezy/commit.py (+8/-247)
breezy/tests/per_workingtree/test_commit.py (+1/-0)
breezy/tests/test_merge.py (+2/-0)
doc/en/release-notes/brz-3.0.txt (+3/-0)
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | #1 |
| Changed in bzr: | |
| importance: | High → Low |
| status: | In Progress → Confirmed |
| assignee: | Jelmer Vernooij (jelmer) → nobody |
| tags: | removed: foreign |
| Changed in brz: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| milestone: | none → 3.0.0 |
| Changed in brz: | |
| status: | Triaged → In Progress |
| Changed in brz: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This has been partially resolved now that record_