workingtree.remove is faulty when removing ''
Bug #64117 reported by
Robert Collins
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Low
|
Unassigned | ||
Breezy |
Triaged
|
Low
|
Unassigned |
Bug Description
When removing '' WorkingTree.remove fails to update the inventory
correctly - it deletes the inventory id for the root, but fails to unset
inventory.root..
it should either fail to do the removal, or correctly set the inventory
to having no root.
affects /products/bzr
--
GPG key available at: <http://
tags: | added: workingtree |
tags: | added: check-for-breezy |
tags: | removed: check-for-breezy |
Changed in bzr: | |
status: | Fix Released → Confirmed |
To post a comment you must log in.
Doing:
wt = bzrlib. workingtree. WorkingTree. open('. ')
wt.lock_read()
inv = wt.inventory
del inv['TREE_ROOT']
does indeed delete all of the entries from the inventory, but leaves inv.root as a real object.
I agree that it should either remove the object, or fail to delete everything.
I'm guessing it has to remove the object, since it may be an intermediate step towards creating a new root.
It is possible for WT.remove() to do this work, but it seems more like an Inventory invariant than a WT one.