workingtree.remove is faulty when removing ''

[Robert Collins]

When removing '' WorkingTree.remove fails to update the inventory
correctly - it deletes the inventory id for the root, but fails to unset
inventory.root..

it should either fail to do the removal, or correctly set the inventory
to having no root.
 affects /products/bzr
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[John A Meinel (jameinel)]

Doing:

wt = bzrlib.workingtree.WorkingTree.open('.')
wt.lock_read()
inv = wt.inventory
del inv['TREE_ROOT']

does indeed delete all of the entries from the inventory, but leaves inv.root as a real object.

I agree that it should either remove the object, or fail to delete everything.
I'm guessing it has to remove the object, since it may be an intermediate step towards creating a new root.
It is possible for WT.remove() to do this work, but it seems more like an Inventory invariant than a WT one.

[Jelmer Vernooij (jelmer)]

I can't change the status for bzr back to "Confirmed" for some reason. :-(

So WorkingTree.remove() still has this behaviour for some trees, but "bzr remove" actually filters out the root, so it's hard for users to trigger this.