bzrlib.transport.http (urllib).get buffers entire response

Bug #555032 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Unassigned
Breezy
Fix Released
High
Unassigned

Bug Description

This can cause MemoryErrors and generally impact performance by losing processing time while content traverses the network.

the guilty line is
> /usr/lib/python2.6/dist-packages/bzrlib/transport/http/__init__.py(132)get()
-> return StringIO(response_file.read())
(Pdb) list
127 # FIXME: some callers want an iterable... One step forward, three steps
128 # backwards :-/ And not only an iterable, but an iterable that can be
129 # seeked backwards, so we will never be able to do that. One such
130 # known client is bzrlib.bundle.serializer.v4.get_bundle_reader. At the
131 # time of this writing it's even the only known client -- vila20071203
132 -> return StringIO(response_file.read())

Vincent Ladeuil (vila)
Changed in bzr:
status: Triaged → Confirmed
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
Changed in brz:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This already appears to have been fixed. No sign of StringIO to be found :)

Changed in brz:
assignee: Jelmer Vernooij (jelmer) → nobody
status: Triaged → Fix Released
Changed in bzr:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.