"Not a branch" should say more about why

Bug #346634 reported by Erik de Castro Lopo
2
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned
Breezy
Triaged
Medium
Unassigned

Bug Description

bzr reports "bzr: ERROR: Not a branch" for when the problem is not that there isn't a branch but that the directory doesn't exist.

    > bzr merge ~/this-does-not-exist
    bzr: ERROR: Not a branch: "/home/erik/this-does-not-exist/".

ignores the fact that "this-does-not-exist" does not in fact exist.

In this case:

    > bzr merge /tmp/
    bzr: ERROR: Not a branch: "/tmp/".

The error message does make sense, because /tmp does exist but isn't a branch.

Revision history for this message
Martin Pool (mbp) wrote :

We all want sane messages, but let's turn this into a specifically actionable bug: you want to see the underlying reason why it's not a branch, like "directory blah does not exist"?

Revision history for this message
Martin Pool (mbp) wrote :

This may not be quite as easy as it seems because we might encounter several errors before deciding we can't open something, and the most recently is not necessarily the most meaningful. But even that would be an improvement.

summary: - Request : Saner error messages
+ "Not a branch" should say more about why
Changed in bzr:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Erik de Castro Lopo (erikd) wrote : Re: [Bug 346634] Re: Request : Saner error messages

Martin Pool wrote:

> We all want sane messages, but let's turn this into a specifically
> actionable bug: you want to see the underlying reason why it's not a
> branch, like "directory blah does not exist"?

If at all possible yes. Peter Miller's libexplain shows just how
good this can be.

Erik
--
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/erikd/Blog/

Jelmer Vernooij (jelmer)
tags: added: ui
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: added: error-reporting
removed: check-for-breezy
Changed in brz:
status: New → Triaged
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.