selftest can't be run in a bound branch

[Vincent Ladeuil]

As mentioned during the behavior change regarding branch.nick, selftest can't be run anymore in bound branches if access to the master branch requires authentication.

This is the case for branches bound to lp branches.

One of the reasons is that some tests use 'bzr --version' as a
'do very little' command and, when the bound branch requires some
password (like any ssh one does)... selftest prompts and hangs..

I use an ssh agent but the test suite (rightly) reset the
SSH_AUTH_SOCK.

bzr selftest -s bb.test_selftest.TestRunBzrSubprocess.test_run_bzr_subprocess

is one such test.

[Vincent Ladeuil (vila)]

Of course the work-around is to unbind the branch, but I use bound branches for a reason.

[Marius Kruger (amanica)]

so either we need to do one of the following
* not show the nick in `bzr --version`
* fix the tests to use some other 'do very little' command. eg. `bzr --help`
* revert the nick behaviour to not read the nick from the master branch (for bound branches)
   I'm still awaiting feedback on this.

[Robert Collins (lifeless)]

This is fixed by my test_selftest work, for that particular test. I don't know if there are other cases of it.

[Vincent Ladeuil (vila)]

Still occurring with bzr revno 5544.