annotating a binary file should raise an exception

[Martin Albisetti]

We currently annotate any file, regardless of them being binary or not.
I don't think there's any good reason to actually annotate a binary file, so bzr should raise an exception when trying to do so, and, of course, do something sensible on the UI about it.

Loggerhead would benefit from this so we don't try and annotate an ISO image through the web :)

[John A Meinel (jameinel)]

We have bzrlib.textfile.check_text_lines() that will raise BinaryFile if there are null bytes in the first 1024 bytes.

I realize we could use this as part of annotate, I'm not sure if Loggerhead would be able to use this more directly.

[Martin Albisetti (beuno)]

> We have bzrlib.textfile.check_text_lines() that will raise BinaryFile if
> there are null bytes in the first 1024 bytes.

Would this read the whole file?
As in, does it scale well to big files?

--
Martin