cargo clippy unclean

[Robert Collins]

I'm just perusing things for memories sake and happened to notice that there are many lints showing during the build.

I think there is a lot of merit in having a clean build: either decide that a particular thing is wrong, and whitelist the lint, or fail the build on the lint if it shows up. That way, when a genuine bug (such as 'permissions.set_readonly(false)' (one of the current lints) shows up, it is clear and can be actioned much more easily.

To reproduce: run 'cargo clippy' in the source tree.