breezy test suite fails in HangupException (in dulwich) initialization

Bug #1890354 reported by Matěj Cepl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Breezy
Fix Released
Medium
Jelmer Vernooij

Bug Description

When running the test suite (with breezy 3.1.0, dulwich 0.20.5, Python 3.8.4) I get these errors in the test suite:

[ 472s] ======================================================================
[ 472s] ERROR: breezy.git.tests.test_remote.ParseHangupTests.test_not_set
[ 472s] ----------------------------------------------------------------------
[ 472s] Traceback (most recent call last):
[ 472s] testtools.testresult.real._StringException: Empty attachments:
[ 472s] log
[ 472s]
[ 472s] Traceback (most recent call last):
[ 472s] File "/home/abuild/rpmbuild/BUILDROOT/breezy-3.1.0-0.x86_64/usr/lib64/python3.8/site-packages/breezy/git/tests/test_remote.py", line 154, in setUp
[ 472s] HangupException(['foo'])
[ 472s] File "/usr/lib64/python3.8/site-packages/dulwich/errors.py", line 143, in __init__
[ 472s] [line.decode('utf-8', 'surrogateescape')
[ 472s] File "/usr/lib64/python3.8/site-packages/dulwich/errors.py", line 143, in <listcomp>
[ 472s] [line.decode('utf-8', 'surrogateescape')
[ 472s] AttributeError: 'str' object has no attribute 'decode'
[ 472s]
[ 472s] ======================================================================
[ 472s] ERROR: breezy.git.tests.test_remote.ParseHangupTests.test_permission_denied
[ 472s] ----------------------------------------------------------------------
[ 472s] Traceback (most recent call last):
[ 472s] testtools.testresult.real._StringException: Empty attachments:
[ 472s] log
[ 472s]
[ 472s] Traceback (most recent call last):
[ 472s] File "/home/abuild/rpmbuild/BUILDROOT/breezy-3.1.0-0.x86_64/usr/lib64/python3.8/site-packages/breezy/git/tests/test_remote.py", line 154, in setUp
[ 472s] HangupException(['foo'])
[ 472s] File "/usr/lib64/python3.8/site-packages/dulwich/errors.py", line 143, in __init__
[ 472s] [line.decode('utf-8', 'surrogateescape')
[ 472s] File "/usr/lib64/python3.8/site-packages/dulwich/errors.py", line 143, in <listcomp>
[ 472s] [line.decode('utf-8', 'surrogateescape')
[ 472s] AttributeError: 'str' object has no attribute 'decode'
[ 472s]
[ 472s] ======================================================================
[ 472s] ERROR: breezy.git.tests.test_remote.ParseHangupTests.test_single_line
[ 472s] ----------------------------------------------------------------------
[ 472s] Traceback (most recent call last):
[ 472s] testtools.testresult.real._StringException: Empty attachments:
[ 472s] log
[ 472s]
[ 472s] Traceback (most recent call last):
[ 472s] File "/home/abuild/rpmbuild/BUILDROOT/breezy-3.1.0-0.x86_64/usr/lib64/python3.8/site-packages/breezy/git/tests/test_remote.py", line 154, in setUp
[ 472s] HangupException(['foo'])
[ 472s] File "/usr/lib64/python3.8/site-packages/dulwich/errors.py", line 143, in __init__
[ 472s] [line.decode('utf-8', 'surrogateescape')
[ 472s] File "/usr/lib64/python3.8/site-packages/dulwich/errors.py", line 143, in <listcomp>
[ 472s] [line.decode('utf-8', 'surrogateescape')
[ 472s] AttributeError: 'str' object has no attribute 'decode'
[ 472s]
[ 472s] ======================================================================
[ 472s] ERROR: breezy.git.tests.test_remote.ParseHangupTests.test_multi_lines
[ 472s] ----------------------------------------------------------------------
[ 472s] Traceback (most recent call last):
[ 472s] testtools.testresult.real._StringException: Empty attachments:
[ 472s] log
[ 472s]
[ 472s] Traceback (most recent call last):
[ 472s] File "/home/abuild/rpmbuild/BUILDROOT/breezy-3.1.0-0.x86_64/usr/lib64/python3.8/site-packages/breezy/git/tests/test_remote.py", line 154, in setUp
[ 472s] HangupException(['foo'])
[ 472s] File "/usr/lib64/python3.8/site-packages/dulwich/errors.py", line 143, in __init__
[ 472s] [line.decode('utf-8', 'surrogateescape')
[ 472s] File "/usr/lib64/python3.8/site-packages/dulwich/errors.py", line 143, in <listcomp>
[ 472s] [line.decode('utf-8', 'surrogateescape')
[ 472s] AttributeError: 'str' object has no attribute 'decode'
[ 472s]
[ 472s] ======================================================================
[ 472s] ERROR: breezy.git.tests.test_remote.ParseHangupTests.test_filter_boring
[ 472s] ----------------------------------------------------------------------
[ 472s] Traceback (most recent call last):
[ 472s] testtools.testresult.real._StringException: Empty attachments:
[ 472s] log
[ 472s]
[ 472s] Traceback (most recent call last):
[ 472s] File "/home/abuild/rpmbuild/BUILDROOT/breezy-3.1.0-0.x86_64/usr/lib64/python3.8/site-packages/breezy/git/tests/test_remote.py", line 154, in setUp
[ 472s] HangupException(['foo'])
[ 472s] File "/usr/lib64/python3.8/site-packages/dulwich/errors.py", line 143, in __init__
[ 472s] [line.decode('utf-8', 'surrogateescape')
[ 472s] File "/usr/lib64/python3.8/site-packages/dulwich/errors.py", line 143, in <listcomp>
[ 472s] [line.decode('utf-8', 'surrogateescape')
[ 472s] AttributeError: 'str' object has no attribute 'decode'
[ 472s]
[ 472s] ----------------------------------------------------------------------
[ 472s] Ran 31487 tests in 428.647s
[ 472s]
[ 472s] FAILED (errors=5, known_failure_count=66)
[ 472s] 4329 tests skipped

Revision history for this message
Matěj Cepl (mcepl) wrote :
Jelmer Vernooij (jelmer)
Changed in brz:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Jelmer Vernooij (jelmer)
milestone: none → 3.1.1
Revision history for this message
Matěj Cepl (mcepl) wrote :

“Fix committed” but where? Which patch is the fix for this?

Jelmer Vernooij (jelmer)
Changed in brz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.