Breezy crashes on a change to submodule

Bug #1880132 reported by Marcin Owsiany on 2020-05-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Breezy
High
Jelmer Vernooij

Bug Description

I'm trying to run silver-platter to propose a simple bump to a git submodule of a repo.

Unfortunately the Python breezy library does not seem to support it and crashes as in the stack trace below

I'm using python3-breezy debian package version 3.0.2-5+b1
I did see pad.lv/1804830 which mentions pad.lv/402814 but these seem fixed?

Traceback (most recent call last):
  File "/usr/bin/svp", line 11, in <module>
    load_entry_point('silver-platter==0.3.0', 'console_scripts', 'svp')()
  File "/usr/lib/python3/dist-packages/silver_platter/__main__.py", line 123, in main
    return callbacks[args.subcommand](args)
  File "/usr/lib/python3/dist-packages/silver_platter/run.py", line 182, in main
    publish_result = publish_changes(
  File "/usr/lib/python3/dist-packages/silver_platter/proposal.py", line 523, in publish_changes
    (proposal, is_new) = ws.propose(
  File "/usr/lib/python3/dist-packages/silver_platter/proposal.py", line 371, in propose
    return propose_changes(
  File "/usr/lib/python3/dist-packages/silver_platter/proposal.py", line 614, in propose_changes
    check_proposal_diff(local_branch, main_branch)
  File "/usr/lib/python3/dist-packages/silver_platter/proposal.py", line 574, in check_proposal_diff
    with tree_merger.make_preview_transform() as tt:
  File "/usr/lib/python3/dist-packages/breezy/merge.py", line 789, in make_preview_transform
    self._compute_transform()
  File "/usr/lib/python3/dist-packages/breezy/merge.py", line 794, in _compute_transform
    entries = self._entries3()
  File "/usr/lib/python3/dist-packages/breezy/merge.py", line 866, in _entries3
    this_executable = this_entry.executable
AttributeError: 'GitTreeSubmodule' object has no attribute 'executable'

Jelmer Vernooij (jelmer) wrote :

Thanks for the bug report. This should be fixed in the 3.1 series. We've just released 3.1 alpha 1 two days ago, and are hoping that 3.1.0 will make it into the Debian archive in the next couple of weeks.

Changed in brz:
milestone: none → 3.1.0
assignee: nobody → Jelmer Vernooij (jelmer)
importance: Undecided → High
status: New → Fix Committed
Jelmer Vernooij (jelmer) on 2020-07-21
Changed in brz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers