plugin loading from entrypoints can be very slow in some cases
Bug #1832868 reported by
Julian Andres Klode
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Breezy |
Fix Released
|
Critical
|
Jelmer Vernooij | ||
Bug Description
bzr info is 0.07s user, brz info is 0.25s user for me in various repositories.
I ran --lsprof info to get the attached file and elapsed time vs 0.142 vs 0.336 seconds.
Related branches
lp:~jelmer/brz/disable-entrypoints-plugins
- Martin Packman: Approve
-
Diff: 218 lines (+41/-21)9 files modifiedbreezy/plugin.py (+6/-1)
breezy/plugins/commitfromnews/__init__.py (+1/-0)
breezy/plugins/darcs/__init__.py (+1/-0)
breezy/plugins/email/__init__.py (+1/-0)
breezy/plugins/fastimport/__init__.py (+1/-0)
breezy/plugins/propose/__init__.py (+1/-0)
breezy/plugins/repodebug/__init__.py (+1/-0)
breezy/tests/test_plugins.py (+25/-20)
doc/en/release-notes/brz-3.0.txt (+4/-0)
Revision history for this message
| Julian Andres Klode (juliank) wrote | #1 |
Revision history for this message
| Julian Andres Klode (juliank) wrote | #2 |
Revision history for this message
| Julian Andres Klode (juliank) wrote | #3 |
Revision history for this message
| Julian Andres Klode (juliank) wrote | #4 |
Revision history for this message
| Julian Andres Klode (juliank) wrote | #5 |
Revision history for this message
| Julian Andres Klode (juliank) wrote | #6 |
Revision history for this message
| Julian Andres Klode (juliank) wrote | #7 |
Revision history for this message
| Julian Andres Klode (juliank) wrote | #8 |
Revision history for this message
| Julian Andres Klode (juliank) wrote | #9 |
Revision history for this message
| Colin Watson (cjwatson) wrote | #10 |
Revision history for this message
| Colin Watson (cjwatson) wrote | #11 |
| Changed in brz: | |
| status: | New → Triaged |
| importance: | Undecided → Critical |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| summary: |
- 2-3 times slower than bzr for simple things + startup 2-3 times slower than bzr in some cases |
| summary: |
- startup 2-3 times slower than bzr in some cases + plugin loading from entrypoints can be very slow in some cases |
| tags: | added: performance plugins |
| Changed in brz: | |
| milestone: | none → 3.0.2 |
| status: | Triaged → Fix Committed |
| Changed in brz: | |
| status: | Fix Committed → Fix Released |
| affects: | brz → ubuntu |
| Changed in ubuntu: | |
| assignee: | Jelmer Vernooij (jelmer) → rashaad lane (zillablack) |
| milestone: | 3.0.2 → none |
| affects: | ubuntu → brz |
| Changed in brz: | |
| assignee: | rashaad lane (zillablack) → Jelmer Vernooij (jelmer) |
To post a comment you must log in.
Same performance difference for log and diff, fwiw.