breezy.tests.blackbox.test_serve.TestBzrServe.test_bzr_serve_port_readonly fails regularly under tarmac

[Jelmer Vernooij]

BRZ_PLUGIN_PATH=-site:-user ./brz selftest breezy.tests.blackbox.test_serve.TestBzrServe.test_bzr_serve_port_readonly fails regularly in tarmac; it gets killed by the alarm.

[Jelmer Vernooij (jelmer)]

It looks like os.kill(pid, SIGINT) is having trouble killing the "bzr serve" process in this case.

[Jelmer Vernooij (jelmer)]

Also failed on launchpad:

FAIL: breezy.tests.blackbox.test_serve.TestBzrServe.test_bzr_serve_port_readonly
----------------------------------------------------------------------
Traceback (most recent call last):
testtools.testresult.real._StringException: log: {{{
75.333 creating config directory: '/tmp/testbzr-LasHYS.tmp/breezy.tests.blackbox.test_serve.TestBzrServe.test_bzr_serve_port_readonly/home/breezy'
75.477 Output of brz '(unknown args)':

75.477 Error for brz '(unknown args)':
brz: ERROR: thread.error: release unlocked lock

Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/build/lib.linux-i686-2.7/breezy/bzr/smart/server.py", line 225, in serve
    self.serve_conn(conn, thread_name_suffix)
  File "/<<PKGBUILDDIR>>/build/lib.linux-i686-2.7/breezy/bzr/smart/server.py", line 285, in serve_conn
    connection_thread.start()
  File "/usr/lib/python2.7/threading.py", line 741, in start
    self.__started.wait()
  File "/usr/lib/python2.7/threading.py", line 615, in wait
    return self.__flag
  File "/usr/lib/python2.7/threading.py", line 289, in __exit__
    return self.__lock.__exit__(*args)
error: release unlocked lock

brz 3.0.0dev1 on python 2.7.12 (Linux-4.4.0-93-generic-i686-athlon-with-
    Ubuntu-16.04-xenial)
arguments: ['/<<PKGBUILDDIR>>/build/scripts-2.7/brz',
    '--no-plugins', 'serve', '--listen', 'localhost', '--port', '0']
plugins:
encoding: 'utf-8', fsenc: 'UTF-8', lang: 'C.UTF-8'

*** Bazaar has encountered an internal error. This probably indicates a
    bug in Bazaar. You can help us fix it by filing a bug report at
        https://bugs.launchpad.net/brz/+filebug
    including this traceback and a description of the problem.
brz: ERROR: thread.error: release unlocked lock

Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/build/lib.linux-i686-2.7/breezy/commands.py", line 1007, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/build/lib.linux-i686-2.7/breezy/commands.py", line 1193, in run_bzr
    ret = run(*run_argv)
  File "/<<PKGBUILDDIR>>/build/lib.linux-i686-2.7/breezy/commands.py", line 756, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/<<PKGBUILDDIR>>/build/lib.linux-i686-2.7/breezy/commands.py", line 780, in run
    return self._operation.run_simple(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/build/lib.linux-i686-2.7/breezy/cleanup.py", line 136, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/<<PKGBUILDDIR>>/build/lib.linux-i686-2.7/breezy/cleanup.py", line 165, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/build/lib.linux-i686-2.7/breezy/builtins.py", line 5542, in run
    protocol(t, listen, port, inet, client_timeout)
  File "/<<PKGBUILDDIR>>/build/lib.linux-i686-2.7/breezy/bzr/smart/server.py", line 494, in serve_bzr
    bzr_server.smart_server.serve()
  File "/<<PKGBUILDDIR>>/build/lib.linux-i686-2.7/breezy/bzr/smart/server.py", line 225, in serve
    self.serve_conn(conn, thread_name_suffix)
  File "/<<PKGBUILDDIR>>/build/lib.linux-i686-2.7/breezy/bzr/smart/server.py", line 285, in serve_conn
    connection_thread.start()
  File "/usr/lib/python2.7/threading.py...