trigger tests for updated reverse test dependencies
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | britney |
Medium
|
Martin Pitt | ||
| | dpkg (Debian) |
Fix Released
|
Unknown
|
||
| | dpkg (Ubuntu) |
Medium
|
Martin Pitt | ||
Bug Description
Tracking down the cause of the php5 stalls, I found that the regression in the php-codecoverage tests was caused not by a regression in php5, which it blocks, but in xdebug, which it did *not* block.
This is because xdebug is a test dependency of php-codecoverage but not a build or runtime dependency of it. As a result, xdebug was allowed to regress the state of php-codecoverage's tests in the release pocket, undetected.
Should we trigger tests for test dependencies as well?
| Martin Pitt (pitti) wrote : | #1 |
| Changed in auto-package-testing: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| summary: |
- packages can regress undetected because of uploads in test (not - build/runtime) dependencies + trigger tests for updated reverse test dependencies |
| Changed in dpkg (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| Changed in dpkg (Debian): | |
| status: | Unknown → New |
| Martin Pitt (pitti) wrote : | #2 |
For the record, summary/decision from the Debian bug report: dpkg-source -b adds a new field
Testsuite-
from the union of all testsuites test depends, minus @ and @builddeps@, without versions, and with alternatives split (i.e. a simple comma separated package list). If the field is present then it overrides the automatically extracted value.
| Changed in dpkg (Ubuntu): | |
| status: | Triaged → In Progress |
| assignee: | nobody → Martin Pitt (pitti) |
| Changed in dpkg (Debian): | |
| status: | New → Fix Released |
| Launchpad Janitor (janitor) wrote : | #3 |
This bug was fixed in the package dpkg - 1.18.9ubuntu1
---------------
dpkg (1.18.9ubuntu1) yakkety; urgency=medium
* Merge with Debian unstable, pulling in fix for dpkg-buildpackage.
dpkg (1.18.9) unstable; urgency=medium
* Require Dpkg::Control::Info in dpkg-buildpackage.
Initially reported by Helmut Grohne <email address hidden>.
Regression introduced in dpkg 1.18.8. Closes: #829542
* Documentation:
- Fix user configuration filename in dpkg-buildpacka
Thanks to Sven Joachim <email address hidden>. Closes: #829546
-- Adam Conrad <email address hidden> Mon, 04 Jul 2016 04:48:25 -0600
| Changed in dpkg (Ubuntu): | |
| status: | In Progress → Fix Released |
| Martin Pitt (pitti) wrote : | #4 |
I implemented this some weeks ago: https:/
| affects: | auto-package-testing → britney |
| Changed in britney: | |
| status: | Triaged → Fix Released |
| assignee: | nobody → Martin Pitt (pitti) |
Yes, we absolutely should. This has been on the wish list for a long time, and about half a year ago Adam and I talked to the Debian dpkg maintainers how to implement this efficiently. I'm linking to the dpkg bug.
In short, the plan is to make dpkg-source add the collection of test dependencies to the .dsc so that they will appear in the archive's Sources.gz. Then we can actually do a query like "what are the reverse test dependencies of package X", which isn't possible right now.