Import recipe from Brewmate causes Brewtarget to stop working

Bug #1192269 reported by Jay on 2013-06-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Brewtarget
Medium
Mik Firestone

Bug Description

OS: Win7 32-bit Ultimate SP1
BrewTarget - 2.0.1

Default Install into Program Files directory. Set Brewtarget.exe to run as Adminstrator

Run Brewtarget and choose import recipe from the File menu.

Navigate to Brewmate recipe sub directory and click on recipe xml file

Error pops up from Brewtarget saying Brewtarget has stopped working. Below is the details from the error:

Problem signature:
  Problem Event Name: APPCRASH
  Application Name: brewtarget.exe
  Application Version: 0.0.0.0
  Application Timestamp: 5137df2c
  Fault Module Name: QtCore4.dll
  Fault Module Version: 4.7.4.0
  Fault Module Timestamp: 4e5f8d4e
  Exception Code: c0000005
  Exception Offset: 0010d542
  OS Version: 6.1.7601.2.1.0.256.1
  Locale ID: 1033
  Additional Information 1: 0a9e
  Additional Information 2: 0a9e372d3b4ad19135b953a78882e789
  Additional Information 3: 0a9e
  Additional Information 4: 0a9e372d3b4ad19135b953a78882e789

BrewTarget should import the recipe xml file from BrewMate.

Mik Firestone (mikfire) wrote :

I'm not familiar with brewmate.

Does the recipe.xml file contain all of your recipes, or just one? Is there some way you could provide me with the recipe.xml file (dropbox, email, etc.) so I can test with it?

Changed in brewtarget:
assignee: nobody → Mik Firestone (mikfire)
Mik Firestone (mikfire) wrote :

Wow. That's an impressive core dump. Okay. I have what I need and will start working on it.

Changed in brewtarget:
importance: Undecided → Medium
status: New → In Progress
Mik Firestone (mikfire) wrote :

I will fix the core dump, because we should handle it better than that, but the real problem is with the brewmate XML file. According to the BeerXML specification, the STYLE record set has 15 required attributes. Since these are required, we don't check to see if they are present or not.

It looks like brewmate didn't implement the specification, since the XML file only shows the style name and is missing the other required attributes. This appears to be the case with both the recipes provided with the software and the recipes I created.

Changed in brewtarget:
status: In Progress → Triaged
Jay (jbrend) wrote :

Thanks Mike -

I can add the XML file from Brewmate if that would help?

Mik Firestone (mikfire) wrote :

Bug fix has been committed with merge request 54.

Changed in brewtarget:
status: Triaged → Fix Committed
Philip (rocketman768) on 2014-01-11
Changed in brewtarget:
milestone: none → 2.0.2
Philip (rocketman768) on 2014-02-02
Changed in brewtarget:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers