Any text typed into Brewday instructions display box causes crash on Mac

[Peter Buelow]

Any text typed into the largest text box in the Brewday notes will cause an instant segfault with the following crash dump.

5 QtCore 0x0000000105674a2a qFatal(char const*, ...) + 170
6 Brewtarget 0x00000001023adf10 QList<Instruction*>::operator[](int) + 96 (qlist.h:477)
7 Brewtarget 0x00000001023afefb BrewDayScrollWidget::saveInstruction() + 75 (BrewDayScrollWidget.cpp:53)
8 Brewtarget 0x00000001025931f1 BrewDayScrollWidget::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) + 689 (moc_BrewDayScrollWidget.cxx:74)
9 QtCore 0x00000001057b1fae QMetaObject::activate(QObject*, QMetaObject const*, int, void**) + 1566

[Mik Firestone (mikfire)]

I'm seeing the same thing on my linux build. Looks like the same core dump too.

[Mik Firestone (mikfire)]

This will be fixed as soon as I get done making the database writes more sane. What's going on is that *any* input into that text edit box generates a textChanged() signal, which in turn calls the saveInstructions(). This results in a long chain, that ends up calling setInstructions() with a null string, and we dump core.

[Philip (rocketman768)]

Does this still happen in upstream/master?

[Mik Firestone (mikfire)]

This was closed back with merge request 21 or 22 -- I'm having a hard time finding exactly the right commit. But it was coincidental with my implementing BtTextWidgets.