brewnote showing weird numbers for efficiency into bk

Bug #1121200 reported by Mik Firestone on 2013-02-10
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Brewtarget
Low
Mik Firestone

Bug Description

Sometimes efficiency into BK and Brewhouse eff are showing "reasonable" numbers (like 72%) and sometimes not (like 5.40%). It kind of looks like some variables aren't getting reset when a new brewnote is loaded.

Mik Firestone (mikfire) on 2013-02-26
Changed in brewtarget:
assignee: nobody → Mik Firestone (mikfire)
status: New → In Progress
Mik Firestone (mikfire) wrote :

This is somewhere actually in the conversion code. The database is showing the number being displayed. I need to fix the translation code and I need to see if I can find a way to fix this without having to reload the entire database.

Mik Firestone (mikfire) on 2013-02-28
Changed in brewtarget:
status: In Progress → Triaged
Mik Firestone (mikfire) wrote :

Somewhere, we changed how we expected the projected points to be stored. In previous versions, we expected them to be stored as points, already converted from the internal representation. In v2.0, we expect them to be stored in Plato and we have to convert them to points.

This leaves us in a somewhat awkward position of being wrong no matter how we do it. I will work on this a bit longer and figure out my best solution -- likely by converting the projected points before we store and making sure we don't convert on import.

Mik Firestone (mikfire) wrote :

That was annoying. Merge request 23 should resolve the problem and clean up the mess left behind.

Changed in brewtarget:
status: Triaged → Fix Committed
Philip (rocketman768) wrote :

Although this is pulled in, I was wondering about the efficiency calcs. If you go to the Bt: Blonde Ale recipe and 'brew it', it shows by default that the efficiency into the boil kettle is 76.4 and the brewhouse efficiency is 83.2. From my understanding, bk efficiency should be strictly greater than brewhouse, since you can only lose sugar between the boil kettle and fermenter. Is that a misconception?

Well, sort of. Unless you were to do something like add sugar after the
mash.

Projected points are calculated based on the total theoretical maximum
amount of sugars available at the end of the mash. If you add sugar after
that point, your brewhouse efficiency will be larger than your extract
efficiency.

I would need to either track two separate maximums (mash and postboil) or I
would have to check to see if there non-mashed sugars available and add
those into the brewhouse calculations.

This isn't a new bug, by the way. My calculations have always had this
problem. I almost never add sugar into my wort, and haven't really gotten
around to fixing it. Open a bug and I will get this fix into the next
release.

Mik

On Sun, Mar 3, 2013 at 9:08 AM, Philip <email address hidden> wrote:

> Although this is pulled in, I was wondering about the efficiency calcs.
> If you go to the Bt: Blonde Ale recipe and 'brew it', it shows by
> default that the efficiency into the boil kettle is 76.4 and the
> brewhouse efficiency is 83.2. From my understanding, bk efficiency
> should be strictly greater than brewhouse, since you can only lose sugar
> between the boil kettle and fermenter. Is that a misconception?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1121200
>
> Title:
> brewnote showing weird numbers for efficiency into bk
>
> Status in Brewtarget:
> Fix Committed
>
> Bug description:
> Sometimes efficiency into BK and Brewhouse eff are showing
> "reasonable" numbers (like 72%) and sometimes not (like 5.40%). It
> kind of looks like some variables aren't getting reset when a new
> brewnote is loaded.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/brewtarget/+bug/1121200/+subscriptions
>

--
In a world of ninja v. pirate, I pilot a Gundam

Philip (rocketman768) on 2013-03-06
Changed in brewtarget:
milestone: none → 2.0.1
Philip (rocketman768) on 2013-03-07
Changed in brewtarget:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers