embed: logo icon opens destination URL inside frame

[mangtronix]

In the embed case the logo icon (IA logo in our case) opens the target URL inside the window. Not sure what the desired behaviour is here. We could open the target URL in a new window or reach up out of the frame and replace the location for the parent document (not sure if this is possible with current browsers).

Originally reported here: https://bugs.edge.launchpad.net/gnubook/+bug/356650

[mangtronix (mang)]

I'm setting the link target to _top for now since that will work for embed and non-embed. The correct setting for embed will be _new but we will revisit that in a more general push to make embed cleaner.

[mangtronix (mang)]

I set the target to _blank in the embed case, so clicking the logo will open a new window.

[mangtronix (mang)]

Bonnie please check that clicking on the Archive logo opens a new window when clicked in the embedded book reader. When in a full window clicking the link should navigate to archive.org.

[Bonnie Real (bonnie-archive)]

It does! The only exception is IE8, in which case archive.org does open in a full window (previously it opened right there in the embed frame), but it opens in the window you are presently in, not a new window.

[mangtronix (mang)]

Hmm works for me on IE8 on XP SP3.