Link to this page view does not link to this page view but the original page I landed on

Bug #1211847 reported by James Alexander
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Internet Archive BookReader
New
Undecided
Unassigned

Bug Description

The Share dialog box 'Link to this page view' is not updated if I scroll to another page and then select 'Share'. I still see the link for the first page that I landed on not the updated page.

Is this the expected behaviour? It does not seem right - I would want and expect to bookmark or share the page I'm currently viewing.

Revision history for this message
James Alexander (james-alexander) wrote :

The fix for this is to add the script -

document.getElementById('pageview').value = document.location;

or similar, to the share constructor functions on or near line 3752 of Bookreader.js.

The line is then -

    jToolbar.find('.share').colorbox({inline: true, opacity: "0.5", href: "#BRshare", onLoad: function() { self.autoStop(); self.ttsStop(); document.getElementById('pageview').value = document.location; } });

This ensures that the location given is the current location at the time when the Share button is clicked not that at page construction time which I believe is the correct Url to reference.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.