Bmdc only highlights "exact" words

Bug #1543565 reported by YamashitaRen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BMDC
Fix Committed
Wishlist
Unassigned

Bug Description

I want BMDC to highlights every word containing "Yama".
Currently, if I add "Yama" to my highlights list, only "Yama" will be highlighted. "Yama:", "@Yama" etc... will not be highlighted.
I think that highlighting every word containing the highlight string should be the default behavior or that an option enabling this behavior should be provided to the user.

M@nk (manky)
Changed in bmdc++:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
M@nk (manky) wrote :

potential fix commited use as $Re:*Yama*

Revision history for this message
YamashitaRen (lemaitre-dulotus) wrote :

Thanks !
It works but it's also highlighthing my pseudo (which has Yama inside) which I think is bad.
Moreover highlighted words aren't notified anymore (I tried having only"Yama" or "$Re:*Yama*" in the highlighting list). Notification works fine from "Appearance>Notify>Highlighting string>Test". I can confirm that this bug was introduced with latest commit.

Revision history for this message
M@nk (manky) wrote :

ok , i didnt test Sound & noti , now its should be fine in all cases

Revision history for this message
YamashitaRen (lemaitre-dulotus) wrote :

Good ! Notification bug is fixed.
You may want to keep in mind that "$Re:*Yama*" is highlighting my pseudo in the chat window : "[15:17:10] <YamashitaRen> Parfait (presque)".
Don't seem to be a really big problem since I can use "$Re:Yama*".

Revision history for this message
YamashitaRen (lemaitre-dulotus) wrote :

Another note : The /me command is triggering highlights too.

Revision history for this message
M@nk (manky) wrote :

its used glob-style paterns now , and also react to *every text in TextView (GtkTextView) , so its work correctly. and i can avoid highlit of <nick> , but not /me since that is regular text.... but i also i think the behavior wich is now is beter...

Revision history for this message
YamashitaRen (lemaitre-dulotus) wrote :

Yeah, that's good enough. Thanks again :)

M@nk (manky)
Changed in bmdc++:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.