Start BleachBit with computer broken on non-English Windows

Bug #458424 reported by Danilo Piazzalunga
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BleachBit
Fix Released
Medium
Andrew Ziem

Bug Description

Localized (non-English) versions of Windows change the names of the Start Menu folder and its subfolders. For example, on the Italian version of Windows, "%USERPROFILE%\Start Menu\Programs\Startup" becomes "%USERPROFILE%\Menu Avvio\Programmi\Esecuzione automatica".

When checking the "Start BleachBit with computer" option on Windows, BleachBIt tries to create the shortcut in a hardcoded path; instead, it should use SHGetSpecialFolderPath to retrieve CSIDL_STARTUP.

Patch attached. Not fully tested because I didn't rebuild the Windows version of BleachBit.

Tags: patch
Revision history for this message
Danilo Piazzalunga (danilopiazza) wrote :
Revision history for this message
Danilo Piazzalunga (danilopiazza) wrote :

For reference, here is the BleachBit.exe.log file containing the error.

Revision history for this message
Andrew Ziem (ahziem1) wrote :

Thank you once for the report and a second time for the patch :)

Changed in bleachbit:
assignee: nobody → Andrew Ziem (ahziem1)
importance: Undecided → Medium
milestone: none → 0.7.1
status: New → Triaged
Revision history for this message
Andrew Ziem (ahziem1) wrote :

Committed in SVN 1408.

Changed in bleachbit:
status: Triaged → Fix Committed
Revision history for this message
Andrew Ziem (ahziem1) wrote :
Changed in bleachbit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.