BUG: Cleaner for Epiphany doesn't work

[Roman Horník]

Hi Andrew, I found that this cleaner does not work. Maybe it's the same mistake as in Firefox- Epiphany is not running, but BB reported that Epiphany is running.

[Andrew Ziem (ahziem1)]

You are correct. Thank you. Fixed in SVN r761

[Roman Horník (roman.hornik)]

This problem unfortunately persists (SVN rev. 761).

[Andrew Ziem (ahziem1)]

I checked it Epiphany 2.26.3 on Fedora 11, and it seems OK. Do you think the lock file (its exact name is printed to the console) is left over from a session that was abruptly ended?

[Roman Horník (roman.hornik)]

BB checks the existence of .lock, or .parentlock?
BleachBit must check the existence of .lock file instead of .parentlock, because .parentlock file is still present in ~/.gnome2/epiphany/mozilla/epiphany after the closing of the Epiphany browser.

[Andrew Ziem (ahziem1)]

Before SVN 761, it checked both. In SVN 761, it only checks the file 'lock'.

http://bleachbit.svn.sourceforge.net/viewvc/bleachbit/trunk/cleaners/epiphany.xml?r1=679&r2=761

Both versions check for a running process called 'epiphany'.

[Roman Horník (roman.hornik)]

That's weird...

........
My cleaner.xml (SVN rev. 761)
<cleaner id="epiphany" os="linux">
  <label>Epiphany</label>
  <description>Web browser</description>
  <running type="exe">epiphany</running>
  <running type="pathname">~/.gnome2/epiphany/mozilla/epiphany/.parentlock</running>
  <running type="pathname">~/.gnome2/epiphany/mozilla/epiphany/lock</running>
  <option id="cache">
    <label>Cache</label>
........

Removed the line # 26... and it works!

Now I run the command:

svn co https://bleachbit.svn.sourceforge.net/svnroot/bleachbit/trunk bleachbit .

Output:

U trunk/debian/bleachbit.dsc
U trunk/debian/debian.changelog
U trunk/cleaners/pidgin.xml
U trunk/cleaners/epiphany.xml <<<<<
U trunk/bleachbit.spec
U trunk/bleachbit/Common.py
U trunk/po/ar.po
U trunk/po/gl.po
U trunk/po/pt_BR.po
U trunk/po/nl.po
U trunk/po/pl.po
U trunk/po/sk.po
U trunk/po/pt.po
U trunk/po/ru.po
U trunk/po/de.po
U trunk/po/sv.po
A trunk/po/id.po
U trunk/po/he.po
Checked out revision 761.
svn: 'bleachbit' does not appear to be a URL

That's weird...

[Roman Horník (roman.hornik)]

Why BleachBit verifies if a process is running and also checks the existence of a .lock file?

[Andrew Ziem (ahziem1)]

Why? The file system is shared but the process is not in the case of a shared home directory on a network file system (common in offices/organizations). I can't think of a case where the lock file is not seen and the process is running, but it's good to be careful. :)

Instead of 'svn co', try this command to download new changes:
$ svn update

If you edit a file locally and want to throw away your changes
$ svn revert cleaners/epiphany.xml

If you want to create a patch showing your change
$ svn diff cleaners/epiphany.xml