Update to NSIS 3.x

[ROCKNROLLKID]

NSIS 3.0 is out with some new features and many bug fixes.

http://nsis.sourceforge.net/Docs/AppendixF.html#v3.0

It's possible 3.1 or even 3.2 for NSIS will be out by the time you get BleachBit 2.0 out, so I guess just update to whatever the latest is when 2.0 is ready.

Maybe it might be possible to now include a auto detect for the uninstaller when upgrading BleachBit to newer versions.

[Andrew Ziem (ahziem1)]

ok

[Andrew Ziem (ahziem1)]

I updated NSIS in the build environment and enabled Unicode in Git commit 9262d1c

[Andrew Ziem (ahziem1)]

Jospeh: It seems odd to mark this "also affects nsis (Ubuntu)" because this is about the private build environment for BleachBit for Windows

[ROCKNROLLKID (slinger1410-deactivatedaccount)]

Reopening. a buffer overflow was detected in 3.0 and was fixed in 3.01. builds aren't released yet, but consider updating as soon as the update is released.

[ROCKNROLLKID (slinger1410-deactivatedaccount)]

3.01 was released on December 11th. It includes the fix for the buffer overflow as well as support for Corsican language, so BleachBit should be able to fully translate into that language now.

Change log for 3.0.1 here: http://nsis.sourceforge.net/Docs/AppendixF.html#v3.01

I am not seeing any issues with this build, so maybe we can cap it here. I will keep an eye on their GitHub page and let you know if I see anything that might be useful to BleachBit.

[Andrew Ziem (ahziem1)]

I am in the process of re-engineering the BleachBit build process to be easier and more reliable using Appveyor. Here it shows they have NSIS 3.0, and they should get 3.01 soon
https://www.appveyor.com/docs/installed-software/

I'll use this ticket to make sure BleachBit gets the latest version

[Andrew Ziem (ahziem1)]

They accepted my request for NSIS 3.01 with a target date of January 8, 2017.

https://github.com/appveyor/ci/issues/1244

[Andrew Ziem (ahziem1)]

The latest BleachBit builds from AppVeyor have NSIS 3.01

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Hans Joachim Desserud (hjd)]

Re: comment #3, I'm not quite sure what the part affecting the Ubuntu package is either. However, nsis has been upgraded to version 3.03-2 in Ubuntu Cosmic, so I believe this issue can be marked as fixed.