please remove shebang from non-executable python files

Bug #1399264 reported by Doktor5000 on 2014-12-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BleachBit
Undecided
Andrew Ziem

Bug Description

The files CLI.py and GUI.py currently have shebangs "#!/usr/bin/env python" but they have no executable permissions.
They are probably not intended to be run directly by users, so please remove the shebang.

$ grep ^#! bleachbit/{CLI,GUI}.py
bleachbit/CLI.py:#!/usr/bin/env python
bleachbit/GUI.py:#!/usr/bin/env python

Otherwise. if those files are intended to be run by users, please add executable permissions.

This was checked against bleachbit 1.6.

Andrew Ziem (ahziem1) wrote :

While it is not typical, the design allows users to directly run CLI.py and GUI.py.

Changed in bleachbit:
milestone: none → 1.8
Doktor5000 (doktor5000) wrote :

Then you should add executable permissions for those two files.

Andrew Ziem (ahziem1) wrote :

Fixed in commit b36a6d5

Changed in bleachbit:
assignee: nobody → Andrew Ziem (ahziem1)
status: New → Fix Committed
Andrew Ziem (ahziem1) wrote :

Released in BleachBit 1.7.7 beta. Please test:
http://bleachbit.sourceforge.net/news/bleachbit-177-beta

Changed in bleachbit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers