Lease fails to end properly if instance is deleted concurrently

Bug #1786073 reported by Pierre Riteau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Blazar
Fix Released
Medium
Unassigned

Bug Description

An instance running on one of the reserved host can be deleted concurrently (by the user) to the execution of the on_end function in the physical host plugin.

This raises a NotFound exception, preventing on_end() from completing successfully, leaving host allocations deleted, but with the lease in ACTIVE state and host left in the reservation's aggregate.

Changed in blazar:
importance: Undecided → Medium
status: New → Triaged
milestone: none → rocky-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to blazar (master)

Reviewed: https://review.openstack.org/589969
Committed: https://git.openstack.org/cgit/openstack/blazar/commit/?id=8c46b5c73e9e92c714c051e8cb165c97fcc8645b
Submitter: Zuul
Branch: master

commit 8c46b5c73e9e92c714c051e8cb165c97fcc8645b
Author: Pierre Riteau <email address hidden>
Date: Wed Aug 8 18:34:50 2018 +0200

    Continue running on_end() when instance deletion fails

    A user can delete their instances while the on_end function is
    executing. This can result in novaclient raising a NotFound exception,
    preventing on_end() from completing successfully. The host allocations
    are deleted at this point, but the hosts are left in the reservation's
    aggregate, preventing future leases from starting.

    This patch catches all exceptions and continues running on_end().

    Change-Id: Ib495a26f9ec2e7eae64e1eaf69a6cf635c3aadcd
    Closes-Bug: #1786073

Changed in blazar:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.